Closed Bug 697086 Opened 8 years ago Closed 8 years ago

Content permission notifications not dismissed on page dismiss

Categories

(Firefox for Android :: General, defect, P2)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: aaronmt, Assigned: gcp)

References

Details

(Keywords: feature)

Attachments

(2 files, 1 obsolete file)

Attached image Nightly (10/25)
See screenshot

STR:
1. http://maps.google.com
2. http://google.com

--
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111025 Firefox/10.0a1
Samsung Galaxy SII (Android 2.3.4)
Assignee: nobody → gpascutto
Priority: -- → P2
Attachment #571012 - Flags: review?(mark.finkle)
Comment on attachment 571012 [details] [diff] [review]
Patch 1. Dismiss popups on page changes


>     void handleLocationChange(final int tabId, final String uri) {

>         tab.updateURL(uri);
>+        mAppContext.mDoorHanger.removeForTab(tabId);

Do we need to worry about calling this from a background thread?

r+, but think about the background thread question
Attachment #571012 - Flags: review?(mark.finkle) → review+
>Do we need to worry about calling this from a background thread?

It's calling PopupWindow.dismiss(), so yeah, it should be in a Runnable on the main thread.
Carrying forward review.
Attachment #571012 - Attachment is obsolete: true
Attachment #571028 - Flags: review+
hg.mozilla.org/projects/birch/rev/473727215fbe
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
20111102040257
http://hg.mozilla.org/projects/birch/rev/2b9de9749c1e
Samsung Nexus S (Android 2.3.6)
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
Keywords: feature
You need to log in before you can comment on or make changes to this bug.