697086 - Content permission notifications not dismissed on page dismiss

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (10/25)

See screenshot

STR:
1. http://maps.google.com
2. http://google.com

--
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111025 Firefox/10.0a1
Samsung Galaxy SII (Android 2.3.4)

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Dismiss popups on page changes

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 571012 [details] [diff] [review]
Patch 1. Dismiss popups on page changes


>     void handleLocationChange(final int tabId, final String uri) {

>         tab.updateURL(uri);
>+        mAppContext.mDoorHanger.removeForTab(tabId);

Do we need to worry about calling this from a background thread?

r+, but think about the background thread question

Comment 3

[Gian-Carlo Pascutto [:gcp]]

>Do we need to worry about calling this from a background thread?

It's calling PopupWindow.dismiss(), so yeah, it should be in a Runnable on the main thread.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch v2. Dismiss popups on page changes

Carrying forward review.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

hg.mozilla.org/projects/birch/rev/473727215fbe

Comment 6

[Aaron Train [:aaronmt]]

20111102040257
http://hg.mozilla.org/projects/birch/rev/2b9de9749c1e
Samsung Nexus S (Android 2.3.6)