The default bug view has changed. See this FAQ.

Content permission notifications not dismissed on page dismiss

VERIFIED FIXED

Status

()

Firefox for Android
General
P2
normal
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: aaronmt, Assigned: gcp)

Tracking

({feature})

unspecified
ARM
Android
feature
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 569352 [details]
Nightly (10/25)

See screenshot

STR:
1. http://maps.google.com
2. http://google.com

--
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111025 Firefox/10.0a1
Samsung Galaxy SII (Android 2.3.4)
(Assignee)

Updated

6 years ago
Assignee: nobody → gpascutto

Updated

6 years ago
Priority: -- → P2
(Assignee)

Comment 1

6 years ago
Created attachment 571012 [details] [diff] [review]
Patch 1. Dismiss popups on page changes
Attachment #571012 - Flags: review?(mark.finkle)
Comment on attachment 571012 [details] [diff] [review]
Patch 1. Dismiss popups on page changes


>     void handleLocationChange(final int tabId, final String uri) {

>         tab.updateURL(uri);
>+        mAppContext.mDoorHanger.removeForTab(tabId);

Do we need to worry about calling this from a background thread?

r+, but think about the background thread question
Attachment #571012 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 3

6 years ago
>Do we need to worry about calling this from a background thread?

It's calling PopupWindow.dismiss(), so yeah, it should be in a Runnable on the main thread.
(Assignee)

Comment 4

6 years ago
Created attachment 571028 [details] [diff] [review]
Patch v2. Dismiss popups on page changes

Carrying forward review.
Attachment #571012 - Attachment is obsolete: true
Attachment #571028 - Flags: review+
(Assignee)

Comment 5

6 years ago
hg.mozilla.org/projects/birch/rev/473727215fbe
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

6 years ago
20111102040257
http://hg.mozilla.org/projects/birch/rev/2b9de9749c1e
Samsung Nexus S (Android 2.3.6)
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed

Updated

5 years ago
Keywords: feature
You need to log in before you can comment on or make changes to this bug.