697087 - Multiple notifications content permission prompt

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (10/25)

See screenshot.

--
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111025 Firefox/10.0a1
Samsung Galaxy SII (Android 2.3.4)

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Multiple prompts

STR: 
1. http://html5demos.com/geo
2. Reload page multiple times

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Replace repeated requests

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 571090 [details] [diff] [review]
Patch 1. Replace repeated requests

Checking for dupes based on the message text isn't the best way. In XUL we give each notification a value or tag, making it easier to match when checking for dupes.

This is incrementally better than what we currently have. I guess we can go with this patch for now, but I think we should file a new bug to switch to use value/tag.

https://developer.mozilla.org/en/XUL/notificationbox  (look for 'value')

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. v2 Replace repeated requests

This should be a more proper fix.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 571112 [details] [diff] [review]
Patch 1. v2 Replace repeated requests

Great! Thanks

Comment 6

[Gian-Carlo Pascutto [:gcp]]

http://hg.mozilla.org/projects/birch/rev/2b9de9749c1e

Comment 7

[Aaron Train [:aaronmt]]

20111102040257
http://hg.mozilla.org/projects/birch/rev/2b9de9749c1e
Samsung Nexus S (Android 2.3.6)