Multiple notifications content permission prompt

VERIFIED FIXED

Status

()

Firefox for Android
General
P3
normal
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: aaronmt, Assigned: gcp)

Tracking

({feature})

unspecified
ARM
Android
feature
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 569353 [details]
Nightly (10/25)

See screenshot.

--
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111025 Firefox/10.0a1
Samsung Galaxy SII (Android 2.3.4)
(Reporter)

Comment 1

6 years ago
Created attachment 569355 [details]
Multiple prompts

STR: 
1. http://html5demos.com/geo
2. Reload page multiple times
(Reporter)

Updated

6 years ago
Summary: Double notifications content permission prompt → Multiple notifications content permission prompt
(Assignee)

Updated

6 years ago
Assignee: nobody → gpascutto

Updated

6 years ago
Priority: -- → P3
(Assignee)

Comment 2

6 years ago
Created attachment 571090 [details] [diff] [review]
Patch 1. Replace repeated requests
Attachment #571090 - Flags: review?(mark.finkle)
Comment on attachment 571090 [details] [diff] [review]
Patch 1. Replace repeated requests

Checking for dupes based on the message text isn't the best way. In XUL we give each notification a value or tag, making it easier to match when checking for dupes.

This is incrementally better than what we currently have. I guess we can go with this patch for now, but I think we should file a new bug to switch to use value/tag.

https://developer.mozilla.org/en/XUL/notificationbox  (look for 'value')
Attachment #571090 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 571112 [details] [diff] [review]
Patch 1. v2 Replace repeated requests

This should be a more proper fix.
Attachment #571090 - Attachment is obsolete: true
Attachment #571112 - Flags: review?(mark.finkle)
Comment on attachment 571112 [details] [diff] [review]
Patch 1. v2 Replace repeated requests

Great! Thanks
Attachment #571112 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/projects/birch/rev/2b9de9749c1e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

6 years ago
20111102040257
http://hg.mozilla.org/projects/birch/rev/2b9de9749c1e
Samsung Nexus S (Android 2.3.6)
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed

Updated

5 years ago
Keywords: feature
You need to log in before you can comment on or make changes to this bug.