Closed Bug 697102 Opened 8 years ago Closed 8 years ago

Fix a typo in xpcom/base/nsIErrorService.idl

Categories

(Core :: XPCOM, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: ishikawa, Assigned: ishikawa)

Details

Attachments

(1 file, 1 obsolete file)

There is a simple typo in the comment in xpcom/base/nsIErrorService.idl, which
is very confusing.

It should be fixed.
Attachment #569365 - Attachment is patch: true
Attachment #569365 - Flags: review+
Attachment #569365 - Flags: checkin?
Please could you tweak your hgrc to automatically add author info (guide here: http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed) + add a commit message when attaching patches, since it makes pushing half a dozen checkin-neededs a lot easier. Thanks :-)
Assignee: nobody → ishikawa
Status: NEW → ASSIGNED
Flags: in-testsuite-
Version: unspecified → Trunk
I re-created the patch in requested format with Username, and check in message.
I tried to use so called "Mercurial Queues", but being a relative newbie to `hg' itself, I bumbled and so the attached patch is actually a part of
a larger patchset that includes a host of other changes in other files.
(I didn't realize Mercurial Queues tries to incorporate all the changes in hg repository as one. I read the explanation in https://developer.mozilla.org/en/Mercurial_Queues  to mean that a set of files under "one directory" be handled as part of patchset creation, but no it is under "one repository".
Oh well.

Please let me know if the file attached looks to be in the format you expect.
Attachment #570745 - Flags: review+
Attachment #570745 - Flags: checkin?
(In reply to Ed Morley [:edmorley] from comment #1)
> Please could you tweak your hgrc to automatically add author info (guide
> here:
> http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed) +
> add a commit message when attaching patches, since it makes pushing half a
> dozen checkin-neededs a lot easier. Thanks :-)

See comment 2

TIA
Attachment #569365 - Attachment is obsolete: true
Attachment #569365 - Flags: checkin?
Comment on attachment 570745 [details] [diff] [review]
The patch in requested format (username, comment, et.)

Great, thanks :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/43135d676c68
Attachment #570745 - Flags: checkin? → checkin+
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/43135d676c68
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.