Closed
Bug 697105
Opened 13 years ago
Closed 13 years ago
Permit spaces as a valid search query in an invalid URL
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: aaronmt, Assigned: mfinkle)
Details
(Whiteboard: [parity-opera][parity-stock][parity-dolphin])
Attachments
(1 file, 1 obsolete file)
4.29 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
STR: 1. "Toronto Ontario" 2. "The URL is not valid and cannot be loaded." ER: https://www.google.com/q=toronto+ontario AR: Dialog prompt -- Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111025 Firefox/10.0a1 Samsung Galaxy SII (Android 2.3.4)
Assignee | ||
Comment 1•13 years ago
|
||
We load URLs directly in browserjs now, so we need to make sure those code paths are using 3RD_PARTY_FIXUP or nsIURIFixup. This patch adds nsIURIFixup to Tab:Add and Tab:Load actions. I do wonder if we should show some kind of error dialog or error content page if the fixup fails.
Assignee: nobody → mark.finkle
Attachment #569598 -
Flags: review?(doug.turner)
Assignee | ||
Comment 2•13 years ago
|
||
Fixed a typo i last patch "URIFixer" -> "URIFixup"
Attachment #569598 -
Attachment is obsolete: true
Attachment #569598 -
Flags: review?(doug.turner)
Attachment #569601 -
Flags: review?(doug.turner)
Comment 3•13 years ago
|
||
Comment on attachment 569601 [details] [diff] [review] patch 2 suppose URIFixup returns null. we silently fail. Is it better to just pass whatever we got to loadURI() or addTab()? createFixupURI(aData, 1); to: createFixupURI(aData, Ci.nsIURIFixup.FIXUP_FLAG_ALLOW_KEYWORD_LOOKUP); or createFixupURI(aData, 1 /* FIXUP_FLAG_ALLOW_KEYWORD_LOOKUP */ ); or similar
Attachment #569601 -
Flags: review?(doug.turner) → review+
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Doug Turner (:dougt) from comment #3) > Comment on attachment 569601 [details] [diff] [review] [diff] [details] [review] > patch 2 > > suppose URIFixup returns null. we silently fail. Is it better to just pass > whatever we got to loadURI() or addTab()? Done. We use the URI if not null, else we pass the original data > createFixupURI(aData, Ci.nsIURIFixup.FIXUP_FLAG_ALLOW_KEYWORD_LOOKUP); Done
Assignee | ||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/186015786b5a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•13 years ago
|
||
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111027 Firefox/10.0a1 Fennec/10.0a1 Samsung Nexus S
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•