Closed Bug 697120 Opened 13 years ago Closed 13 years ago

Show favicon on all entries in awesomebar

Categories

(Firefox for Android Graveyard :: General, defect, P1)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect

Tracking

(firefox11 fixed, fennec11+)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: lucasr, Assigned: lucasr)

Details

Attachments

(3 files)

(1/3) Don't store "all pages" cursor as private property
4.24 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review
(2/3) Show favicons on AwesomeBar's All Pages and Bookmarks tabs
7.28 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review
(3/3) Show favicon on AwesomeBar's history tab
6.58 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review
All lists in awesome bar are missing favicons.
Just a cleanup I did on the way.
Attachment #569940 - Flags: review?(mark.finkle)
Attachment #569940 - Attachment description: Don't store "all pages" cursor as private property → (1/3) Don't store "all pages" cursor as private property
Attachment #569942 - Flags: review?(mark.finkle)
Attachment #569940 - Flags: review?(mark.finkle) → review+
FYI: AwesomeBar will only actually start showing favicons for the pages once we start caching/storing favicon images in Android's browser database. I'm finishing patches for bug 697194 which will do that. But those patches don't depend on favicons to be present so it's ok to push them after review.
Attachment #569941 - Flags: review?(mark.finkle) → review+
Attachment #569942 - Flags: review?(mark.finkle) → review+
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111027 FIrefox/10.0a1 Fennec/10.0a1
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: