Show favicon on all entries in awesomebar

VERIFIED FIXED

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
6 years ago
9 months ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
All
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
All lists in awesome bar are missing favicons.
(Assignee)

Comment 1

6 years ago
Created attachment 569940 [details] [diff] [review]
(1/3) Don't store "all pages" cursor as private property

Just a cleanup I did on the way.
Attachment #569940 - Flags: review?(mark.finkle)
(Assignee)

Updated

6 years ago
Attachment #569940 - Attachment description: Don't store "all pages" cursor as private property → (1/3) Don't store "all pages" cursor as private property
(Assignee)

Comment 2

6 years ago
Created attachment 569941 [details] [diff] [review]
(2/3) Show favicons on AwesomeBar's All Pages and Bookmarks tabs
Attachment #569941 - Flags: review?(mark.finkle)
(Assignee)

Comment 3

6 years ago
Created attachment 569942 [details] [diff] [review]
(3/3) Show favicon on AwesomeBar's history tab
Attachment #569942 - Flags: review?(mark.finkle)
Attachment #569940 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 4

6 years ago
FYI: AwesomeBar will only actually start showing favicons for the pages once we start caching/storing favicon images in Android's browser database. I'm finishing patches for bug 697194 which will do that. But those patches don't depend on favicons to be present so it's ok to push them after review.
Attachment #569941 - Flags: review?(mark.finkle) → review+
Attachment #569942 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 5

6 years ago
Pushed:
http://hg.mozilla.org/projects/birch/rev/8952aa31d274
http://hg.mozilla.org/projects/birch/rev/e82f061db80e
http://hg.mozilla.org/projects/birch/rev/fb29004f0dfa
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111027 FIrefox/10.0a1 Fennec/10.0a1
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.