697122 - Show only label on awesome bar tabs while keeping native tab look

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Lucas Rocha (:lucasr)]

Due to a bug in Android, tabs with only label set still have empty space for the unset tab icon. We'll have to implement custom tab layout with only a label but still keeping the native tab theme.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Show only a label on AwesomeBar's tab indicators

I had to come up with some temporary assets to get the custom tab indicator to look good enough. I used the design mockups for awesomebar screen as a reference. It looks very similar to what they've proposed but I'm sure I'll have to tweak it later.

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Screenshot

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I might be mistaken, but I think there is a white line under all tabs, but the selected tab has a thicker line width.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 570717 [details] [diff] [review]
Show only a label on AwesomeBar's tab indicators

Overall this is good, but I would like to see if we can make some progress on the selected states and maybe using a different color (not white) for the tab bottom borders, since that conflicts with the list row backgrounds.

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> I might be mistaken, but I think there is a white line under all tabs, but
> the selected tab has a thicker line width.

The line under all tabs is there. It's just not visible in this screenshot because the list view has white background too.

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: Screenshot

Tweaked the assets to add a separator between the tabs' bottom line and the list view. I'm still not entirely happy with it but it's better than having no clear separation between tabs and list view. We'll get real assets from Ian soon, so this is not a big deal.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 570717 [details] [diff] [review]
Show only a label on AwesomeBar's tab indicators

r+ with the new assets. I agree, we can tweak this later with ibarlow assets.

Comment 8

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/projects/birch/rev/16889566ccc4

Comment 9

[Aaron Train [:aaronmt]]

20111101040211
http://hg.mozilla.org/projects/birch/rev/7203d86d5868
Samsung Nexus S (Android 2.3.6)