Show only label on awesome bar tabs while keeping native tab look

VERIFIED FIXED

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
6 years ago
11 months ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
All
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Due to a bug in Android, tabs with only label set still have empty space for the unset tab icon. We'll have to implement custom tab layout with only a label but still keeping the native tab theme.
(Assignee)

Comment 1

6 years ago
Created attachment 570717 [details] [diff] [review]
Show only a label on AwesomeBar's tab indicators

I had to come up with some temporary assets to get the custom tab indicator to look good enough. I used the design mockups for awesomebar screen as a reference. It looks very similar to what they've proposed but I'm sure I'll have to tweak it later.
Attachment #570717 - Flags: review?(mark.finkle)
(Assignee)

Comment 2

6 years ago
Created attachment 570718 [details]
Screenshot
I might be mistaken, but I think there is a white line under all tabs, but the selected tab has a thicker line width.
Comment on attachment 570717 [details] [diff] [review]
Show only a label on AwesomeBar's tab indicators

Overall this is good, but I would like to see if we can make some progress on the selected states and maybe using a different color (not white) for the tab bottom borders, since that conflicts with the list row backgrounds.
Attachment #570717 - Flags: review?(mark.finkle) → review-
(Assignee)

Comment 5

6 years ago
(In reply to Mark Finkle (:mfinkle) from comment #3)
> I might be mistaken, but I think there is a white line under all tabs, but
> the selected tab has a thicker line width.

The line under all tabs is there. It's just not visible in this screenshot because the list view has white background too.
(Assignee)

Comment 6

6 years ago
Created attachment 570734 [details]
Screenshot

Tweaked the assets to add a separator between the tabs' bottom line and the list view. I'm still not entirely happy with it but it's better than having no clear separation between tabs and list view. We'll get real assets from Ian soon, so this is not a big deal.
Attachment #570718 - Attachment is obsolete: true
Comment on attachment 570717 [details] [diff] [review]
Show only a label on AwesomeBar's tab indicators

r+ with the new assets. I agree, we can tweak this later with ibarlow assets.
Attachment #570717 - Flags: review- → review+
(Assignee)

Comment 8

6 years ago
Pushed: http://hg.mozilla.org/projects/birch/rev/16889566ccc4
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
20111101040211
http://hg.mozilla.org/projects/birch/rev/7203d86d5868
Samsung Nexus S (Android 2.3.6)
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.