Closed Bug 697175 Opened 8 years ago Closed 8 years ago

Split up TOK_EQOP into individual types for all its subtypes

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
It's really only used to handle equality checks all together, but just putting individual types in a contiguous range and doing a range comparison will work as well.
Attachment #569419 - Flags: review?(cdleary)
This changes a == b == c == d from having constant stack/parse tree depth to linear depth.  Unless someone has evidence that this pattern gets real use (remember the left stuff decays, so you every term compared to true/false from the left hand side), this seems like more intuitive, more intelligent behavior to me.
Attachment #569419 - Flags: review?(cdleary) → review+
https://hg.mozilla.org/mozilla-central/rev/6df63324d385
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.