Last Comment Bug 697175 - Split up TOK_EQOP into individual types for all its subtypes
: Split up TOK_EQOP into individual types for all its subtypes
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-25 10:37 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2011-11-09 05:21 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (7.30 KB, patch)
2011-10-25 10:37 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
cdleary: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2011-10-25 10:37:34 PDT
Created attachment 569419 [details] [diff] [review]
Patch

It's really only used to handle equality checks all together, but just putting individual types in a contiguous range and doing a range comparison will work as well.
Comment 1 Jeff Walden [:Waldo] (remove +bmo to email) 2011-10-25 11:19:07 PDT
This changes a == b == c == d from having constant stack/parse tree depth to linear depth.  Unless someone has evidence that this pattern gets real use (remember the left stuff decays, so you every term compared to true/false from the left hand side), this seems like more intuitive, more intelligent behavior to me.
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2011-11-08 10:31:45 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/6df63324d385
Comment 3 Marco Bonardo [::mak] (Away 6-20 Aug) 2011-11-09 05:21:53 PST
https://hg.mozilla.org/mozilla-central/rev/6df63324d385

Note You need to log in before you can comment on or make changes to this bug.