697178 - The awesome screen long menu press doesn't do anything

Status: VERIFIED WONTFIX

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Doug Turner (:dougt)]

when using the awesome screen, we need a way to dismiss the keyboard.  traditionally, you just long press on the menu key and the keyboard will be dismissed.

Comment 1

[Doug Turner (:dougt)]

this only effects some phones

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: (1/2) Store AwesomeBar's text entry in a property

Just taking a easy bug to start the day :-) Now back to the P1!

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: (2/2) Dismiss VKB on long menu key press in AwesomeBar

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Dismiss VKB on long menu key press in AwesomeBar

Just rebased to latest birch. First patch is not necessary anymore as Sriram added the private text property as part of another patch.

Comment 5

[Madhava Enros [:madhava]]

There's another bug related (bug 701014) - the keyboard should dismiss as soon as the user "fingers-down" on anything other than the keyboard or the input field (i.e. panning the awesomelist).

This is the most natural way to dismiss the keyboard.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Lucas - I tested this patch on my Nexus One. Wihtout the patch, the keyboard hides and shows correctly if I long tap on the MENU button. With the patch, the keyboard hides, but does not show.

Maybe you need to explicitly handle the "show the keyboard if not visible" case in the patch.

Comment 7

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #6)
> Lucas - I tested this patch on my Nexus One. Wihtout the patch, the keyboard
> hides and shows correctly if I long tap on the MENU button. With the patch,
> the keyboard hides, but does not show.
> 
> Maybe you need to explicitly handle the "show the keyboard if not visible"
> case in the patch.

I just found out that in Galaxy S, the long press on Menu key actually maps to Search key. So, maybe the correct fix would be to make Search key toggle keyboard and focus on entry in AwesomeBar activity. It would make sense even on devices that have the Search key anyway. Patch coming.

Comment 8

[Lucas Rocha (:lucasr)]

Attachment: Toggle VKB in AwesomeBar when search is requested

It would be useful to try that on a device that has the 'Search' key, just in case.

Comment 9

[Lucas Rocha (:lucasr)]

Stepping back a bit: maybe this bug is just a WONTFIX. We shouldn't try to work around the inconsistencies among different Android devices. On Galaxy S, long press on menu key is the search key. So, we should simply respect that.

In terms of using search key, I think the strictly correct behaviour would be:
1. While on primary browser UI, if you press Search key, it will take you to AwesomeBar screen (already done).
2. While on AwesomeBar screen, if you press Search key, it will take you back to primary browser UI.

This would be consistent with the behavior of other Android apps like GMail: the Search key is used to toggle the Search UI (AwesomeBar, in our case) on and off in the app.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Lucas Rocha (:lucasr) from comment #9)
> Stepping back a bit: maybe this bug is just a WONTFIX. We shouldn't try to
> work around the inconsistencies among different Android devices. On Galaxy
> S, long press on menu key is the search key. So, we should simply respect
> that.
> 
> In terms of using search key, I think the strictly correct behaviour would
> be:
> 1. While on primary browser UI, if you press Search key, it will take you to
> AwesomeBar screen (already done).
> 2. While on AwesomeBar screen, if you press Search key, it will take you
> back to primary browser UI.
> 
> This would be consistent with the behavior of other Android apps like GMail:
> the Search key is used to toggle the Search UI (AwesomeBar, in our case) on
> and off in the app.

This is also consistent with the stock browser. Asking for UX input here. Madhava, what say you?

Comment 11

[Madhava Enros [:madhava]]

Yes - search button in, search button out makes sense.

Comment 12

[Lucas Rocha (:lucasr)]

(In reply to Madhava Enros [:madhava] from comment #11)
> Yes - search button in, search button out makes sense.

Ok, then this bug is a WONTFIX. I'll open a separate bug to implement the behaviour for search key.

Comment 13

[Catalin Suciu [:csuciu]]

Closing per above comment