Closed Bug 697265 Opened 8 years ago Closed 8 years ago

Support clipboard operations in edit fields

Categories

(Firefox for Android :: General, defect, P3)

All
Android
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox11 --- verified
fennec 11+ ---

People

(Reporter: alexp, Assigned: mfinkle)

References

Details

(Whiteboard: [QA+])

Attachments

(1 file, 1 obsolete file)

Need to add a context menu with Copy/Paste/Select All commands.
Assignee: nobody → wjohnston
Priority: -- → P3
Duplicate of this bug: 705395
Blocks: 705201
Attached patch WIP Patch (obsolete) — Splinter Review
WIP adds Copy, Paste, Select All and Copy All.
Duplicate of this bug: 709457
Attached patch patchSplinter Review
Wes' patch looked OK to me. I tweaked it a bit:
* Added strings
* Moved the "Select Input Method" to the ClipboardHelper and made sure it would appear at the bottom of the context menu

Seems to work ok for me.
Assignee: wjohnston → mark.finkle
Attachment #580435 - Attachment is obsolete: true
Attachment #581346 - Flags: review?(mbrubeck)
Comment on attachment 581346 [details] [diff] [review]
patch

>+    matches: function(aElement) {
>+      if (NativeWindow.contextmenus.textContext.matches(aElement)) {
>+        let flavors = ["text/unicode"];
>+        return ClipboardHelper.clipboard.hasDataMatchingFlavors(flavors, flavors.length, Ci.nsIClipboard.kGlobalClipboard);
>+      }
>+    }

Please add an explicit "return false" for the case where the "if" expression is false.
Attachment #581346 - Flags: review?(mbrubeck) → review+
Thanks mark!
https://hg.mozilla.org/mozilla-central/rev/96a644cb3158
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Flags: in-litmus?(fennec)
Whiteboard: [QA+]
Depends on: 710704
tracking-fennec: --- → 11+
Existent testcases:
- https://litmus.mozilla.org/show_test.cgi?id=33768 for test run 11 and 
- https://litmus.mozilla.org/show_test.cgi?id=43066 for test run 12
Flags: in-litmus?(fennec) → in-litmus+
Verified on:
Nightly 12.0a1 (2012-01-16) HTC Desire Z
Aurora 11.0a2 (2012-01-15) HTC Desire Z

Context menu with Copy/Paste/Select All/Select Input Method commands is displayed in edit fields.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.