697265 - Support clipboard operations in edit fields

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Alex Pakhotin (:alexp)]

Need to add a context menu with Copy/Paste/Select All commands.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: WIP Patch

WIP adds Copy, Paste, Select All and Copy All.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Wes' patch looked OK to me. I tweaked it a bit:
* Added strings
* Moved the "Select Input Method" to the ClipboardHelper and made sure it would appear at the bottom of the context menu

Seems to work ok for me.

Comment 5

[Matt Brubeck (:mbrubeck)]

Comment on attachment 581346 [details] [diff] [review]
patch

>+    matches: function(aElement) {
>+      if (NativeWindow.contextmenus.textContext.matches(aElement)) {
>+        let flavors = ["text/unicode"];
>+        return ClipboardHelper.clipboard.hasDataMatchingFlavors(flavors, flavors.length, Ci.nsIClipboard.kGlobalClipboard);
>+      }
>+    }

Please add an explicit "return false" for the case where the "if" expression is false.

Comment 6

[Wesley Johnston (:wesj)]

Thanks mark!

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/mozilla-central/rev/96a644cb3158

Comment 8

[Andreea Pod]

Existent testcases:
- https://litmus.mozilla.org/show_test.cgi?id=33768 for test run 11 and 
- https://litmus.mozilla.org/show_test.cgi?id=43066 for test run 12

Comment 9

[Carla Nadastean]

Verified on:
Nightly 12.0a1 (2012-01-16) HTC Desire Z
Aurora 11.0a2 (2012-01-15) HTC Desire Z

Context menu with Copy/Paste/Select All/Select Input Method commands is displayed in edit fields.