697271 - XMLHttpRequest.send() should use JS coercion rules

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Per the spec, if XHR.send is called with a type of argument it does not recognize (Blob, ArrayBuffer, Document, FormData) it should use normal JS coercion rules to convert any other value to a string. Obviously we should additionally support the set of additional types that we support internally (nsISupportsString?, nsIInputStream).

That means that for the following calls, we should get the following results:

xhr.send(2)  ->  "2"
xhr.send(false)  ->  "false"
xhr.send(new XMLHttpRequest)  ->  "[Object XMLHttpRequest]"
xhr.send({ toString: function() { return "foo" } })  ->  "foo"

This is what the "[AllowAny]" extended parameter on the .send(DOMString) signature means.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Perhaps we should just fix XPCVariant::GetAsWStringWithSize to do the right thing.
Or Send could take jsval as parameter.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Ccing mrbkap to see if changing GetWStringWithSize is feasible.

Changing to jsval would work, though we have lots of C++ callers that we need to keep in mind somehow.

I also think you can get the jsval out of the nsIVariant

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This is WFM with the Paris bindings, right?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Indeed.