IonMonkey: Support JSOP_CALLPROP

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: masterofhats, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 569523 [details]
method.js

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; InfoPath.2; .NET4.0C; .NET4.0E; MS-RTC LM 8)

Steps to reproduce:

I executed the attached js, which essentially calls an object's method, using the js shell:

js --ion --ion-eager mehtod.js


Actual results:

I got

[MIR] Analying script js-samples/method.js:8
[Abort] Unsupported opcode: callprop (line 9)


Expected results:

IonMonkey should have compiled the function and the contained method call.
This is expected behavior, since IonMonkey is still in the early stages, and there are many things we haven't yet implemented. We don't even support calling global functions yet (bug 694169). This also depends on us supporting JSOP_GETPROP.

I've renamed the bug so that we can get back to it once we're at that point.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: IonMonkey seems not to support method calls → IonMonkey: Support JSOP_CALLPROP
Blocks: 684381
Created attachment 587510 [details] [diff] [review]
Handle JSOP_CALLPROP as JSOP_GETPROP.

With Bug 712714 resolved in-tree, JSOP_CALLPROP is the same as JSOP_GETPROP.
Attachment #587510 - Flags: review?(dvander)
Attachment #587510 - Flags: review?(dvander) → review+
Created attachment 587522 [details] [diff] [review]
Handle JSOP_CALLPROP as JSOP_GETPROP, v2

JSOP_SWAP needs to be followed by JSOP_NOTEARG in the context of JSOP_CALLPROP.
Attachment #587510 - Attachment is obsolete: true
Attachment #587522 - Flags: review?(dvander)
Attachment #587522 - Flags: review?(dvander) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/d601339c1bea
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.