697299 - Disable preferences before Gecko is loaded

Status: VERIFIED FIXED

Description

[Brian Nicholson (:bnicholson)]

Created attachment 569531 [details] [diff] [review]
disables menu item before gecko is ready

If the user tries to view the preferences activity before Gecko has been loaded, the screen won't be populated with the user's preferences.  This patch prevents the preferences activity from being shown before Gecko has been loaded.

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 569531 [details] [diff] [review]
disables menu item before gecko is ready

Review of attachment 569531 [details] [diff] [review]:
-----------------------------------------------------------------

looks good.  two nits.  post another patch, i'll r+

::: embedding/android/GeckoApp.java
@@ +101,5 @@
>      private PopupWindow mTabsTray;
>      private TabsAdapter mTabsAdapter;
>      public DoorHanger mDoorHanger;
>      private static boolean isTabsTrayShowing;
> +    private static boolean sIsGeckoReady = false;

can you rename isTabsTrayShowing to sIsTabsTrayShowing while you are here?

@@ +400,5 @@
>          sMenu = menu;
>          MenuInflater inflater = getMenuInflater();
>          inflater.inflate(R.layout.gecko_menu, menu);
> +        if (sIsGeckoReady)
> +            menu.findItem(R.id.preferences).setEnabled(true);

how would sIsGeckoReady ever be true here?  You probably can just drop these two lines.

Comment 2

[Brian Nicholson (:bnicholson)]

Created attachment 569536 [details] [diff] [review]
updated with renamed sIsTabsTrayShowing

Comment 3

[Brian Nicholson (:bnicholson)]

re: how would sIsGeckoReady ever be true here?  You probably can just drop these two lines.

the menu is recreated every time the activity is recreated
e.g., the view is rotated or the user clicks back and resumes fennec again without quitting first

Comment 4

[Doug Turner (:dougt)]

http://hg.mozilla.org/projects/birch/rev/6dae4cc31859

Comment 5

[Aaron Train [:aaronmt]]

When Gecko is ready, are you able to flip android:enabled="false" to true? If a user has the menu bar open, after Gecko is ready, the Preferences item is still greyed out.

Comment 6

[Brian Nicholson (:bnicholson)]

Created attachment 569855 [details] [diff] [review]
additional patch

we need to do the update on the UI thread.  this patch fixes that (and addresses the problem aaron mentioned).

Comment 7

[Brian Nicholson (:bnicholson)]

reopened for new patch

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 569536 [details] [diff] [review]
updated with renamed sIsTabsTrayShowing

w/ the other patch to post the UI manipulation to the right thread.

Comment 9

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/projects/birch/rev/0716912a1f7f

Comment 10

[Dave Hunt [:davehunt] ⌚️UTC+1]

Verified on Samsung Galaxy S2 during 11/11/11 testday.