697351 - Implement a has() trap on nodelist that doesn't involve dealing with property descriptors

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

As the summary says.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Implement has() on the nodelist proxy handler so that we don't have to do the property descriptor song and dance for it.

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 569610 [details] [diff] [review]
Implement has() on the nodelist proxy handler so that we don't have to do the property descriptor song and dance for it.

Review of attachment 569610 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/dombindings.cpp
@@ +821,5 @@
> +    JSBool protoHasProp;
> +    bool ok = JS_HasPropertyById(cx, proto, id, &protoHasProp);
> +    if (ok)
> +        *bp = protoHasProp;
> +    return ok;

Isn't it fine to do

  return JS_HasPropertyById(cx, proto, id, bp);

?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Isn't it fine to do

Sadly, no.  That's what I wrote first, but bp is a bool* and JS_HasPropertyById has JSBool* as its last argument, and the two are not compatible.

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/2fef1412e0e8

Thanks for the fast review!

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8f1b74f0b569