697466 - Allow triggering PGO builds on an arbitrary revision from self-serve

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[(not currently active) Ted Mielczarek]

We currently don't have a way to trigger PGO builds on an arbitrary revision. This bit us when someone pushed a changeset to inbound which turned only the PGO tests orange. We need to be able to trigger PGO builds+tests on other revisions in order to determine the changeset that's actually at fault.

Comment 1

[Phil Ringnalda (:philor)]

I very nearly backed out an entire merge (from a branch which appears not to do even periodic PGO, which is pretty awesome in its own right) over this lack. Instead, I pushed six backouts to try, failed to catch the intermittent Windows PGO failure in any of them, and let it slide, so it's now fully latched onto the tree, and will go to Aurora tomorrow.

Next time, I'll just back stuff out whether it's reasonable to do so or not.

Comment 2

[Chris AtLee [:catlee]]

have a patch, just needs testing

Comment 3

[Chris AtLee [:catlee]]

Attachment: Allow triggering of PGO builds from self-serve

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 573397 [details] [diff] [review]
Allow triggering of PGO builds from self-serve

>diff --git a/buildapi/scripts/selfserve-agent.py b/buildapi/scripts/selfserve-agent.py

Were you tempted to factor out the common code between do_new_pgobuild_at_revision() and do_new_nightly_at_revision() ?

Comment 5

[Chris AtLee [:catlee]]

Attachment: Allow triggering of PGO builds from self-serve

comme ca?

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 573418 [details] [diff] [review]
Allow triggering of PGO builds from self-serve

lgtm