Closed Bug 697496 Opened 13 years ago Closed 12 years ago

Build warning: WebGLContext.cpp:557:10: warning: unused variable ‘preferOpenGL’

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 711799

People

(Reporter: dholbert, Unassigned)

References

(Blocks 1 open bug)

Details

I get this build warning on linux:
> WebGLContext.cpp:557:10: warning: unused variable ‘preferOpenGL’

It looks like the variable is declared unconditionally, but is only used #ifdef XP_WIN.
http://mxr.mozilla.org/mozilla-central/source/content/canvas/src/WebGLContext.cpp#557
http://mxr.mozilla.org/mozilla-central/source/content/canvas/src/WebGLContext.cpp?mark=651-651#649

Perhaps we should shift this variable down to be inside the XP_WIN chunk where it's used?  (or, leave it where it is, but wrap it in #ifdefs?)
This was fixed as part of bug 711799.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.