Closed
Bug 697629
Opened 13 years ago
Closed 13 years ago
nsToolkit "negative leak" on every run
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: jruderman, Assigned: enndeakin)
References
Details
(Keywords: regression)
Attachments
(1 file)
643 bytes,
patch
|
Details | Diff | Splinter Review |
1. https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx64-debug/1319655607/ (built from e1ae143cc842) 2. mkdir ~/pz/ 3. XPCOM_MEM_LEAK_LOG=2 NightlyDebug.app/Contents/MacOS/firefox -profile ~/pz/ 4. Quit Result: 18446744073709551615 (≡ -1) nsToolkit objects remain How is it that Tinderbox is green with such a simple test failing?
Comment 1•13 years ago
|
||
Bug 503879 took out the NS_COUNT_CTOR(nsToolkit) from nsToolkit::nsToolkit, but left in the corresponding NS_COUNT_DTOR.
Blocks: 503879
Reporter | ||
Comment 2•13 years ago
|
||
So if this isn't causing Tinderbox failures, does that mean nsToolkit *is* leaking on Tinderbox?
Assignee | ||
Comment 3•13 years ago
|
||
How odd. I saw that and thought I fixed it before checking in. It doesn't cause a leak -- it's just the counting that is off as it never increments when the toolkit is created, but decrements on delete, causing it to result in a count of -1.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•13 years ago
|
||
Checked in to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/e0802a531ced
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e0802a531ced
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•