Last Comment Bug 697666 - Don't build the jstracer by default
: Don't build the jstracer by default
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: Matheus Kerschbaum
:
Mentors:
Depends on: 693815
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-26 22:53 PDT by Matheus Kerschbaum
Modified: 2011-11-01 06:03 PDT (History)
20 users (show)
matjk7: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.01 KB, patch)
2011-10-26 22:56 PDT, Matheus Kerschbaum
dmandelin: review+
Details | Diff | Splinter Review

Description Matheus Kerschbaum 2011-10-26 22:53:45 PDT
+++ This bug was initially created as a clone of Bug #693815 +++

Now that the tracer is disabled we should consider not building it by default, for a small win in binary/installer size.
Comment 1 Matheus Kerschbaum 2011-10-26 22:56:00 PDT
Created attachment 569907 [details] [diff] [review]
patch
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-10-27 11:03:01 PDT
Comment on attachment 569907 [details] [diff] [review]
patch

This looks fine, but I'd rather one of the js people sign off on it.
Comment 3 Nicholas Nethercote [:njn] 2011-10-27 18:32:06 PDT
Matheus, can you measure the binary/installer size win?
Comment 4 David Anderson [:dvander] 2011-10-27 18:41:13 PDT
I have a local patch that removes the tracer entirely, it was about ~500KB from the js binary on Linux.
Comment 5 Nicholas Nethercote [:njn] 2011-10-27 18:55:33 PDT
I'd like browser-level measurements, before and after :)  I guess it's libxul that will end up smaller?
Comment 6 Ryan VanderMeulen [:RyanVM] 2011-10-27 19:44:24 PDT
At least on Windows, libmozjs is still built separate from libxul.
Comment 8 Matt Brubeck (:mbrubeck) 2011-10-31 11:22:04 PDT
https://hg.mozilla.org/mozilla-central/rev/8c0a324fc4ed

Note You need to log in before you can comment on or make changes to this bug.