697689 - XHR broken on local filesystem

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: Testcase

Steps to reproduce:
1. Download the attachment.
2. Open the attachment on the local volume (file:// URLs).

Actual Result:
error event will be fired.
Oddly, .response will return Blob object despite the failure.

Expected result:
load event should be fired (load shouls success).

This test will not fail on the network (http:// URLs).

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

Seekable streams will complain if OnDataAvailable succeeded but didn't consume the data.
https://mxr.mozilla.org/mozilla-central/source/netwerk/base/src/nsInputStreamPump.cpp#509

Comment 2

[Boris Zbarsky [:bzbarsky]]

> Seekable streams will complain if OnDataAvailable succeeded but didn't consume the data.

Not just seekable streams.  The OnDataAvailable contract is very clear: if it does not consume the data it needs to throw.  Says so right in the interface documentation.

Comment 3

[Rocco Stilo]

My result:

3: 895/895
[object Blob]
895
7
load
loadend
3: 895/895
[object Blob]
895
3
load
loadend

Comment 4

[Masatoshi Kimura [:emk]]

(In reply to Rocco Stilo from comment #3)
Does your build contain a patch of bug 689008? It was pushed very recently.
Anyway, the current code should be fixed because it violates the nsIStreamListener contract as bz pointed out.
https://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsIStreamListener.idl#69
>     * be read without blocking the calling thread.  The onDataAvailable impl
>     * must read exactly |aCount| bytes of data before returning.

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: patch v2

Updated a comment according to bz's advice.

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: patch for check in

Comment 7

[Ed Morley [:emorley]]

In my queue, which is going via try then onto inbound:
https://tbpl.mozilla.org/?tree=Try&rev=d3d2522ed095

Thanks :-)

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e331396fa1b0

Comment 9

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/e331396fa1b0