Closed
Bug 697856
Opened 13 years ago
Closed 13 years ago
Removed Unused Function Definitions in nsFaviconService.h
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: felix, Assigned: felix)
Details
Attachments
(1 file)
|
3.30 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
DoSetAndLoadFaviconForPage is an unimplemented function definition. SetAndLoadFaviconForPage is being forward declared by an idl
checkAndNotify is unreferenced anywhere else
SetFaviconUrlForPageInternal is unreferenced anywhere else
Attachment #570102 -
Flags: review?(mak77)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 570102 [details] [diff] [review]
Removed Unused Function Definitions in nsFaviconService.h
Review of attachment 570102 [details] [diff] [review]:
-----------------------------------------------------------------
ugh, looks like I forgot to cleanup the header file some time ago. Could you also update the comment at http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/aboutCertError.xhtml#66 that refers to DoSetAndLoadFaviconForPage to just say SetAndLoadFaviconForPage
Attachment #570102 -
Flags: review?(mak77) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•