Closed Bug 697856 Opened 8 years ago Closed 8 years ago

Removed Unused Function Definitions in nsFaviconService.h

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: felix, Assigned: felix)

Details

Attachments

(1 file)

DoSetAndLoadFaviconForPage is an unimplemented function definition. SetAndLoadFaviconForPage is being forward declared by an idl

checkAndNotify is unreferenced anywhere else

SetFaviconUrlForPageInternal is unreferenced anywhere else
Attachment #570102 - Flags: review?(mak77)
Comment on attachment 570102 [details] [diff] [review]
Removed Unused Function Definitions in nsFaviconService.h

Review of attachment 570102 [details] [diff] [review]:
-----------------------------------------------------------------

ugh, looks like I forgot to cleanup the header file some time ago. Could you also update the comment at http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/aboutCertError.xhtml#66 that refers to DoSetAndLoadFaviconForPage to just say SetAndLoadFaviconForPage
Attachment #570102 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/bb4a290222a3
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.