697899 - outlines are drawn outside (expanded by) overflow of text outside its bounding box

Status: RESOLVED DUPLICATE of bug 480888

(Core :: Layout, defect)

Description

[Leon Sorokin]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:10.0a1) Gecko/20111027 Firefox/10.0a1
Build ID: 20111027031040

Steps to reproduce:

a horizontal 2px mystery spacing appears between css "outline" and element background. only happens in FF.

might be related to or dupe of Bug 687311


Actual results:

http://jsfiddle.net/CZKrY/


Expected results:

no white inner space

Comment 1

[j.j.]

Mozilla/5.0 (Windows NT 5.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
cofirming

Comment 2

[j.j.]

Attachment: Reporter's testcase

This is a regression (works in Fx3.6) while bug 687311 is not.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I don't see this on Linux, in the 64-bit 2011-10-27-03-10-40-mozilla-central nightly.

Comment 4

[philippe (part-time)]

It is there on FX 7.01 , recent Aurora & Nightly on 10.6.8
Fx 4.01 and 5.0 display without gaps - I don't have 6.0x.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I do see this on Mac.  It's a 1px gap, not 2px.

The frame dump looks like this:

              Inline(span)(0)@0xc66ba0 {0,96,3703,960} [content=0x1b4d2b00] [vis-overflow=-120,-60,3943,1080] [scr-overflow=0,0,3703,960] [sc=0xc66878]<
                Text(0)@0xc66be8 [run=0x1b4d3310][0,9,T]  {0,0,3703,960} [state=00000000d0600000] [content=0x1b4d2bf0] [vis-overflow=-60,0,3823,960] [scr-overflow=0,0,3703,960] sc=0xc668e0 pst=:-moz-non-element<
                  "some text"
                >

so the textframe's overflow in fact extends to the left and right of the inline's content area by 1px (compare -60 to 0 and 3823 to 3703).  The outline is, of course, drawn around the visual overflow area.

In particular, what's happening is that the text actually paints outside the area it claims to take up (which is pretty common for text, actually, especially when doing subpixel positioning).

So I believe the behavior here is in fact correct, assuming outlines go around visual overflow.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Oh, and of course the gap could well be 2px with different font metrics or a different default font or a different font rasterizer.

Comment 7

[Leon Sorokin]

yeah, for me it's 1px on the left, 2px on right

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Outlines shouldn't really go around the visual overflow. They should go around the border-box and outlines for parts of the same element should be combined somehow.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Mostly agreed, though I tend to think they should include the border boxes of descendants.  It's probably not worth tracking a third overflow area to do that; perhaps it's cheap enough to compute that at paint time?

That said, maybe we should have this discussion in one bug rather than three...

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This should be fixed by bug 480888 (in either Monday's or Tuesday's nightly build, I hope).