horizontal align char editfield doesn't appear in dialog

VERIFIED FIXED in mozilla0.9

Status

()

Core
Editor
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: Brade, Assigned: Charles Manske)

Tracking

Trunk
mozilla0.9
PowerPC
Mac System 8.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

18 years ago
Create a table with one of the cells having a horizontal alignment on a 
character.  Click in that cell and bring up the properties pane for that cell.  
Notice that the character isn't visible so it can't be changed.
(Reporter)

Comment 1

18 years ago
given bug #2212, I question if we should support this in our dialog at all.
Depends on: 2212
Summary: halign character doesn't show up in dialog → horizontal align char editfield doesn't appear in dialog
(Assignee)

Comment 2

18 years ago
I discussed the issue with layout and they said we should supply the UI as we
should.
This is very easy to fix -- didn't set "hidden" attribute on textfield during
startup. Patch is forthcomming.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 3

18 years ago
Created attachment 25901 [details] [diff] [review]
Initialize hidden state for align character textfield
(Assignee)

Comment 4

18 years ago
Note that fix also changes "collapse" to "hidden", which is what we should use
to hide elements.
Whiteboard: FIX IN HAND
(Reporter)

Comment 5

18 years ago
The above patch doesn't work; in fact, I can no longer set the character at all.

I still think that we shouldn't let users try to set this.  It doesn't lay out 
correctly which makes us look dumb when the user sets this.
Whiteboard: FIX IN HAND
(Assignee)

Comment 6

18 years ago
But if we remove UI, what do we do when we encounter this attribute in an
existing page? We don't want to convert it to only those we want to show.

Comment 7

18 years ago
wouldn't it show up in the advanced dialog? and can't it be displayed in the 
text filed for the values but just not be a selectable item?
(Assignee)

Comment 8

18 years ago
The point is if "char" is the attribute value, what do we show in the menu?
A menu must contain all possible attribute values.
(Assignee)

Comment 9

18 years ago
Created attachment 25950 [details] [diff] [review]
A better fix.
(Assignee)

Comment 10

18 years ago
Last attachment fixes problem with not getting initial "char" attribute value.
Upon further thought, "collapse" does seem to be the right attribute to use.
Whiteboard: FIX IN HAND

Comment 11

18 years ago
I can understand wanting to show all legal, known values. but if we do not have 
the underlying infrastructure to display the alignment corectly, maybe we 
shouldn't allow folks to pick it.
(Assignee)

Comment 12

18 years ago
Created attachment 26059 [details] [diff] [review]
Remove support for align="char" from table dialog
(Assignee)

Comment 13

18 years ago
The last fix removes support for align="char" in the table dialog.
If this is encountered in an existing page, we will not change it unless user
selects an alignment from the horizontal alignment menulist.

Comment 14

18 years ago
btw, I took the sample from the spec:
<TABLE border="1">
           <COLGROUP>
           <COL><COL align="char" char=".">
           <THEAD>
           <TR><TH>Vegetable <TH>Cost per kilo
           <TBODY>
           <TR><TD>Lettuce        <TD>$1
           <TR><TD>Silver carrots <TD>$10.50
           <TR><TD>Golden turnips <TD>$100.30
           </TABLE>

and tried it in 4.x, 6.0 and IE 5 and none of them support the function. ANd 
just as an fyi, the spec has this to say about char:

char = character [CN] 
This attribute specifies a single character within a text fragment to act as an 
axis for alignment. The default value for this attribute is the decimal point 
character for the current language as set by the lang attribute (e.g., the 
period (".") in English and the comma (",") in French). User agents are not 
required to support this attribute. 

Note the last sentence.

Comment 15

18 years ago
sr=sfraser
(Assignee)

Updated

18 years ago
No longer depends on: 2212
(Assignee)

Comment 16

18 years ago
UI for "char" is removed.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Updated

18 years ago
Whiteboard: FIX IN HAND

Comment 17

17 years ago
verified in 4/5 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.