Closed Bug 697986 Opened 8 years ago Closed 8 years ago

Ads show up in history

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: snorp, Assigned: blassey)

Details

Attachments

(1 file, 1 obsolete file)

If you go to dairyqueen.com (may also have to click 'standard site' link), doubeclick urls show up in your history. I reckon that those are iframes, and we accidentally add them in response to the document load event.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → blassey.bugs
Attachment #570432 - Flags: review?(doug.turner)
Just wondering, do we want to save about: or chrome: pages? Mozilla Places does not.
Attached patch patchSplinter Review
Attachment #570432 - Attachment is obsolete: true
Attachment #570432 - Flags: review?(doug.turner)
Attachment #570448 - Flags: review?(doug.turner)
Comment on attachment 570448 [details] [diff] [review]
patch

Review of attachment 570448 [details] [diff] [review]:
-----------------------------------------------------------------

typically value then flag field:

if (! aFlags & VisitFlags::TOP_LEVEL)
Attachment #570448 - Flags: review?(doug.turner) → review+
http://hg.mozilla.org/projects/birch/rev/f853e2b1e753
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
20111031040210
http://hg.mozilla.org/projects/birch/rev/b7bbb5708b42
Samsung Galaxy SII
Status: RESOLVED → VERIFIED
So I guess this is the reason why links that are directing a location inside a frame, aren't shown as visited?
http://people.mozilla.org/~mwargers/tests/dom/parentframe_ahrefvisited_inside_frame.html
You need to log in before you can comment on or make changes to this bug.