697986 - Ads show up in history

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

If you go to dairyqueen.com (may also have to click 'standard site' link), doubeclick urls show up in your history. I reckon that those are iframes, and we accidentally add them in response to the document load event.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Just wondering, do we want to save about: or chrome: pages? Mozilla Places does not.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

See http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsNavHistory.cpp#1325

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 570448 [details] [diff] [review]
patch

Review of attachment 570448 [details] [diff] [review]:
-----------------------------------------------------------------

typically value then flag field:

if (! aFlags & VisitFlags::TOP_LEVEL)

Comment 6

[Doug Turner (:dougt)]

http://hg.mozilla.org/projects/birch/rev/f853e2b1e753

Comment 7

[Aaron Train [:aaronmt]]

20111031040210
http://hg.mozilla.org/projects/birch/rev/b7bbb5708b42
Samsung Galaxy SII

Comment 8

[Martijn Wargers (dead)]

So I guess this is the reason why links that are directing a location inside a frame, aren't shown as visited?
http://people.mozilla.org/~mwargers/tests/dom/parentframe_ahrefvisited_inside_frame.html