Last Comment Bug 697992 - Use DebugOnly/NS_WARN_IF_FALSE in dom/src/storage/nsDOMStorage.cpp
: Use DebugOnly/NS_WARN_IF_FALSE in dom/src/storage/nsDOMStorage.cpp
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla10
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-28 08:26 PDT by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2011-11-03 10:23 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use DebugOnly/NS_WARN_IF_FALSE in dom/src/storage/nsDOMStorage.cpp (2.17 KB, patch)
2011-10-28 09:37 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
no flags Details | Diff | Review
Use DebugOnly/NS_WARN_IF_FALSE in dom/src/storage/nsDOMStorage.cpp (1.74 KB, patch)
2011-10-28 11:23 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
mak77: review+
honzab.moz: feedback+
respindola: checkin+
Details | Diff | Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-10-28 08:26:00 PDT

    
Comment 1 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-10-28 09:37:58 PDT
Created attachment 570287 [details] [diff] [review]
Use DebugOnly/NS_WARN_IF_FALSE in dom/src/storage/nsDOMStorage.cpp

https://tbpl.mozilla.org/?tree=Try&rev=c55eaf1b8015
Comment 2 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-10-28 11:23:14 PDT
Created attachment 570312 [details] [diff] [review]
Use DebugOnly/NS_WARN_IF_FALSE in dom/src/storage/nsDOMStorage.cpp

https://tbpl.mozilla.org/?tree=Try&rev=4e728fd19be8
Comment 3 Marco Bonardo [::mak] 2011-10-28 14:38:31 PDT
Comment on attachment 570312 [details] [diff] [review]
Use DebugOnly/NS_WARN_IF_FALSE in dom/src/storage/nsDOMStorage.cpp

Review of attachment 570312 [details] [diff] [review]:
-----------------------------------------------------------------

It looks fine to me, does it compile? I don't know if some of the headers in this file already includes mozilla/Util.h
Comment 4 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-10-28 15:31:36 PDT
Comment on attachment 570312 [details] [diff] [review]
Use DebugOnly/NS_WARN_IF_FALSE in dom/src/storage/nsDOMStorage.cpp

https://hg.mozilla.org/integration/mozilla-inbound/rev/a92ec8fb2ab8
Comment 5 Marco Bonardo [::mak] 2011-10-29 01:49:43 PDT
https://hg.mozilla.org/mozilla-central/rev/a92ec8fb2ab8

Note You need to log in before you can comment on or make changes to this bug.