Closed Bug 698095 Opened 13 years ago Closed 13 years ago

Tab count increment/decrement needs animation


(Firefox for Android Graveyard :: General, defect, P3)



(firefox11 fixed, fennec11+)

Tracking Status
firefox11 --- fixed
fennec 11+ ---


(Reporter: sriram, Assigned: sriram)



(3 files, 3 obsolete files)

When user opens a new tab or closes a tab, the tab count should be shown, with an animation.
Attached patch Patch (obsolete) — Splinter Review
This patches does a small animation for tab addition and deletion.

Method used:
* A TextSwitcher is visible when the animation happens, and the image in the button is hidden (using a transparent color). This ensures that the button still receives the "touch" event to add/view tabs.
* The image button is made to use <level-list> for cleaner code. A max value of 100 is set for "down arrow", as people tend not to open more than 100 tabs anytime.
* Since the animations are smaller, I used them via code. I would also prefer moving them to separate files so that we have a good MVC pattern.

Problems I see:
* I am using a 500ms time for transition for the numbers, and a 500ms before showing the "+" or down arrow in the button. This might be too fast to notice. The time needed for transition must be decided.
* There is a visual glitch in sudden transition from number to image to number. I cannot use a fade-in/fade-out on the image, as it is a part of the button. If there is a need for a smoother transition, its better to come up with a "ButtonSwitcher" of our own.
Assignee: nobody → sriram
Attachment #570602 - Flags: review?(mark.finkle)
Attached patch Option 2: WIP (obsolete) — Splinter Review
This patch is same as the previous one. Except that, the "plus" and "more" images don't go away when the counter animation happens. The number stays on top of the image for 500ms and goes away. This reduces the visual clutter a bit.

(The padding and spacing aren't perfect yet. They can be perfected, if we plan to go with this option)
Attachment #570604 - Flags: review?(mark.finkle)
Priority: -- → P3
I am trying to fix this space between the two. But I'm unable to do it in all means. This needs more exploration. Probably it has to do with the font's baseline, which I'm failing to understand. This is avoiding the "overlap" being visible on animation. Other than that, my animation works now.
Attached patch Patch (obsolete) — Splinter Review
This patch does tab-counter animation with no overlap of digits. This uses TextSwitcher to achieve the same.
Attachment #570602 - Attachment is obsolete: true
Attachment #570604 - Attachment is obsolete: true
Attachment #570602 - Flags: review?(mark.finkle)
Attachment #570604 - Flags: review?(mark.finkle)
Attachment #573620 - Flags: review?(mark.finkle)
Attached image bad background
Patch looks OK, but the background of the text number is wrong. (Nexus One on Gingerbread)
Attached patch PatchSplinter Review
This patch fixes the background of the TextSwitcher.
Attachment #573865 - Flags: review?(mark.finkle)
Comment on attachment 573865 [details] [diff] [review]

Looks good
Attachment #573865 - Flags: review?(mark.finkle) → review+
Attachment #573620 - Attachment is obsolete: true
Attachment #573620 - Flags: review?(mark.finkle)
Closed: 13 years ago
Resolution: --- → FIXED
Seems like we could write tests here to keep track of tab counts and visibility.  Is there a reason why we aren't including such tests?
Samsung Galaxy SII (Android 2.3.4)
Flags: in-litmus?(fennec)
OS: Mac OS X → Android
Hardware: x86 → ARM
Whiteboard: [QA+]
Test case created: BFT- Tabbed Browsing:
Flags: in-litmus?(fennec) → in-litmus+
Whiteboard: [QA+]
tracking-fennec: --- → 11+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.