Closed Bug 698100 Opened 8 years ago Closed 8 years ago

Sync FrameState entries based on tracker

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: bhackett1024, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
As described in 685358 comment 4, the FrameState's current behavior of scanning all entries in OOL and inline sync paths can cost a lot of time.  This behavior was introduced with TI due to the need to keep the entire stack synced when making calls.  Given this requirement, it is faster on large scripts to scan tracked entries instead.  The attached patch reduces the sqlite compile time in bug 687127 from ~5250ms to ~4900ms.
Attachment #570360 - Flags: review?(dvander)
Attachment #570360 - Flags: review?(dvander) → review+
https://hg.mozilla.org/mozilla-central/rev/1b4d0987b18d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.