Last Comment Bug 698107 - Return nsnull instead of false
: Return nsnull instead of false
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla11
Assigned To: Jeff Muizelaar [:jrmuizel]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-28 14:38 PDT by Jeff Muizelaar [:jrmuizel]
Modified: 2011-11-09 05:31 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Attachments
Return nsnull instead of false (547 bytes, patch)
2011-10-28 14:38 PDT, Jeff Muizelaar [:jrmuizel] 		bzbarsky: review+
Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Jeff Muizelaar [:jrmuizel] 2011-10-28 14:38:52 PDT 
Created attachment 570368 [details] [diff] [review]
Return nsnull instead of false

Caught by a clang warning.
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2011-10-28 20:30:46 PDT 
Comment on attachment 570368 [details] [diff] [review]
Return nsnull instead of false

r=me
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-11-01 16:10:41 PDT 
Jeff, planning to check this in?
Comment 3 Jeff Muizelaar [:jrmuizel] 2011-11-01 16:41:10 PDT 
Yes, but if you beat me to it I wouldn't complain
Comment 4 Marco Bonardo [::mak] 2011-11-09 05:31:43 PST 
https://hg.mozilla.org/mozilla-central/rev/2b40312773a5
Note You need to log in before you can comment on or make changes to this bug.