Closed Bug 698187 Opened 8 years ago Closed 8 years ago

Sync pluginCrashedUI with changes from Firefox (Bug 665196 and Bug 688083).

Categories

(SeaMonkey :: General, defect)

defect
Not set

Tracking

(seamonkey2.7 fixed)

RESOLVED FIXED
seamonkey2.7
Tracking Status
seamonkey2.7 --- fixed

People

(Reporter: iann_bugzilla, Assigned: philip.chee)

References

Details

Attachments

(2 files, 1 obsolete file)

We need to update notification.xml to reflect changes from firefox's browser.js
Bug 665196 - Change in-content plugin crash UI to submit a crash report and reload the page in one step.
Bug 688083 - With in-content plugin crash, send crash report option should be synced amongst windows/tabs.
Bug 688925 - Plugin-Crash: Unique Notification Bar Help Link to Differentiate Source.
We don't need Bug 688925 until we have some specific help content to link to
Summary: Port Bug 665196 (submit crash report & reload plugin in one step), Bug 688083 (sync submit crash report checkbox between instances) and Bug 688925 (Plugin-Crash: Unique Notification Bar Help Link to Differentiate Source) to SeaMonkey → Sync pluginCrashedUI with changes from Firefox (Bug 665196 and Bug 688083).
Attached patch Patch v1.0. (obsolete) — Splinter Review
Attachment #570491 - Flags: review?(iann_bugzilla)
IanN suggested over IRC that we pass the status and submitChk vars directly to retryPluginPage() rather than make it compute the values again.
Attachment #570491 - Attachment is obsolete: true
Attachment #570491 - Flags: review?(iann_bugzilla)
Attachment #570719 - Flags: review?(iann_bugzilla)
Attachment #570719 - Flags: review?(iann_bugzilla) → review+
Attachment #570719 - Flags: superreview?(neil)
Attachment #570719 - Flags: superreview?(neil) → superreview+
Pushed:
http://hg.mozilla.org/comm-central/rev/3f817c4323c9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.7
I tried to be too clever and tried to improve on the Firefox patch. :P
Since this is a checkbox, we should not preventDefault so that the checkbox can be toggled on click.
Attachment #578272 - Flags: review?(neil)
Attachment #578272 - Flags: review?(neil) → review+
Comment on attachment 578272 [details] [diff] [review]
Patch v2.0 Additional fix: Don't use addLinkClickCallback as it uses preventDefault.

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/bb873519e249
Blocks: 723970
You need to log in before you can comment on or make changes to this bug.