Closed Bug 698190 Opened 13 years ago Closed 13 years ago

Fix things after landing of mozilla::clamped function from bug 695303

Categories

(MailNews Core :: Backend, defect)

defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 10.0

People

(Reporter: iannbugzilla, Assigned: t.matsuu)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 695303 removed NS_CLAMP and added the mozilla::clamped function
Need to fix mailnews to use the new function instead.
Depends on: 695303
Severity: normal → blocker
NS_CLAMP is used only in nsMsgProtocol.cpp in c-c.

/mailnews/base/util/nsMsgProtocol.cpp
    line 142 -- *aQoSBits = (PRUint8) NS_CLAMP(val, 0, 0xff);
Attachment #570472 - Flags: review?(mbanner)
Comment on attachment 570472 [details] [diff] [review]
Use mozilla::clamped instead of NS_CLAMP

In most cases in the m-c patch a "using namespace mozilla;" line was added, not sure it really matters but that is the version of patch I created and tested.
Assignee: nobody → t.matsuu
Status: NEW → ASSIGNED
Comment on attachment 570472 [details] [diff] [review]
Use mozilla::clamped instead of NS_CLAMP

thx for the patch - it'll take a bit for me to build it, but it looks fine and we might as well get the tree greener.
Attachment #570472 - Flags: review?(mbanner) → review+
(In reply to David :Bienvenu from comment #3)
Thank you for reviewing. However I suppose "using namespace mozilla;" approach which is suggested by Ian is better.

I'll test a new patch using "using namespace mozilla;". Could you wait for check-in for a while?
Using "using namespace mozilla;"
Attachment #570472 - Attachment is obsolete: true
Attachment #570483 - Flags: review?(dbienvenu)
Comment on attachment 570483 [details] [diff] [review]
v2 Use mozilla::clamped instead of NS_CLAMP

sure, looks ok.
Attachment #570483 - Flags: review?(dbienvenu) → review+
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/cdb6254a77f9
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
You need to log in before you can comment on or make changes to this bug.