Closed Bug 698217 Opened 8 years ago Closed 5 years ago

Simplify new static Preference methods

Categories

(Core :: Preferences: Backend, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(2 files)

Bug 656826 created helpful static utility methods but they are written in terms of the existing preference branch methods. Instead the preference branch methods should be written in terms of the static utility methods.
Not really part of this bug but it was annoying me.

I left the calls that ensure the pref service has been constructed as I wasn't sure whether it was safe to remove them. It does make them look unused though.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #570552 - Flags: review?(roc)
Comment on attachment 570552 [details] [diff] [review]
DeCOMtaminate nsIPrefServiceInternal

Review of attachment 570552 [details] [diff] [review]:
-----------------------------------------------------------------

This could be pretty damaging to extension compatiblity, couldn't it?

Can you look at AMO to estimate extension usage?

Otherwise looks good.
(In reply to Robert O'Callahan from comment #2)
> This could be pretty damaging to extension compatiblity, couldn't it?
Well, not the [noscript] methods. I'll find out about readExtensionPrefs.
(In reply to neil@parkwaycc.co.uk from comment #3)
> (In reply to Robert O'Callahan from comment #2)
> > This could be pretty damaging to extension compatiblity, couldn't it?
> Well, not the [noscript] methods. I'll find out about readExtensionPrefs.
Mossop says that nobody uses it.
Comment on attachment 570552 [details] [diff] [review]
DeCOMtaminate nsIPrefServiceInternal

Review of attachment 570552 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent.
Attachment #570552 - Flags: review?(roc) → review+
Try run for 385a3974dfb1 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=385a3974dfb1
Results (out of 18 total builds):
    failure: 18
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/neil@parkwaycc.co.uk-385a3974dfb1
Try run for 1bebd4f603f6 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=1bebd4f603f6
Results (out of 193 total builds):
    success: 187
    warnings: 6
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/neil@parkwaycc.co.uk-1bebd4f603f6
Comment on attachment 570552 [details] [diff] [review]
DeCOMtaminate nsIPrefServiceInternal

Pushed changeset 921e1db5cf11 to mozilla-central.
Try run for 6de97f7e8f1c is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=6de97f7e8f1c
Results (out of 193 total builds):
    exception: 2
    success: 104
    warnings: 87
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/neil@parkwaycc.co.uk-6de97f7e8f1c
Try run for c65cee834455 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c65cee834455
Results (out of 193 total builds):
    exception: 1
    success: 188
    warnings: 4
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/neil@parkwaycc.co.uk-c65cee834455
Attachment #571951 - Flags: review?(roc)
Comment on attachment 571951 [details] [diff] [review]
Bypass pref branch for simple calls

Pushed changeset d01685629ad2 to mozilla-central.
Looks like I forgot to resolve this.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.