698228 - [ImageMap] Don't use GetPrimaryFrame when not needed

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Since we have the strange setup that area elements get the primary frame of
img, there is really no need to use GetPrimaryFrame in nsImageMap.
Especially because we should get rid of that strange setup.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 570504 [details] [diff] [review]
patch

surkov, could you test that a11y still works ok.
It is the only using GetBoundsForAreaContent, IIRC.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

https://tbpl.mozilla.org/?tree=Try&rev=aca8dcfb5f49

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 570504 [details] [diff] [review]
patch

>-  if (NS_SUCCEEDED(aEvent->GetTarget(getter_AddRefs(target))) && target) {
>+  if (mImageFrame &&
>+      NS_SUCCEEDED(aEvent->GetTarget(getter_AddRefs(target))) && target) {

Hmm, this doesn't seem right.  Shouldn't we still do 
area->HasFocus(focus) even if the frame is gone?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Well, if mImageFrame is null, ImageMap has been disconnected from imageframe.

I'll move the place of mImageFrame check to be where if (imgFrame) used to be.

Comment 5

[alexander :surkov (:asurkov)]

(In reply to Olli Pettay [:smaug] from comment #1)

> surkov, could you test that a11y still works ok.
> It is the only using GetBoundsForAreaContent, IIRC.

Marco, could you make sure imagemaps work and expose correct boundaries please?

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 570504 [details] [diff] [review]
patch

> I'll move the place of mImageFrame check to be where if (imgFrame) used to
> be.

ok, r=mats with that.

Comment 7

[alexander :surkov (:asurkov)]

Comment on attachment 570504 [details] [diff] [review]
patch

sorry it took long time, f=me. I don't see a difference between x,y,width,height values between patched trunk Firefox and Firefox 8.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/b70bd1e1fd1e