698248 - Remove FORCE_USE_PIC

Status: RESOLVED FIXED

Description

[Gregory Szorc [:gps]]

Unless MXR is letting me down, it appears FORCE_USE_PIC=1 is defined 58 times in 57 files but it isn't being used anywhere. Unless there is a need for it, it should probably be removed from all the Makefiles.

Comment 1

[Mark Banner (:standard8)]

Looks like it was bug 648911 that removed the use of this http://hg.mozilla.org/mozilla-central/rev/8e846d7f21ea

Comment 2

[Gregory Szorc [:gps]]

Created attachment 570769 [details] [diff] [review]
Remove FORCE_USE_PIC, v1

Here is a straightforward patch that removes FORCE_USE_PIC and associated comments from all the Makefile.in's.

Comment 3

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Comment on attachment 570769 [details] [diff] [review]
Remove FORCE_USE_PIC, v1

I didn't actually verify that these are all of the occurrences in m-c, but this looks good.

Comment 4

[Gregory Szorc [:gps]]

Created attachment 571061 [details] [diff] [review]
Remove FORCE_USE_PIC, v1 - reviewed

Same patch as before. Updated subject line to reflect review. Need checkin.

Comment 5

[Gregory Szorc [:gps]]

I got level 3, so I pushed this to build-system: http://hg.mozilla.org/projects/build-system/rev/e9e6741defd4

Comment 6

[Gregory Szorc [:gps]]

Merged to m-c: https://hg.mozilla.org/mozilla-central/rev/e9e6741defd4