Closed Bug 698248 Opened 10 years ago Closed 9 years ago

Remove FORCE_USE_PIC

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file, 1 obsolete file)

Remove FORCE_USE_PIC, v1 - reviewed
32.51 KB, patch
gps
: review+
Details | Diff | Splinter Review 
Unless MXR is letting me down, it appears FORCE_USE_PIC=1 is defined 58 times in 57 files but it isn't being used anywhere. Unless there is a need for it, it should probably be removed from all the Makefiles.
Looks like it was bug 648911 that removed the use of this http://hg.mozilla.org/mozilla-central/rev/8e846d7f21ea
Depends on: 648911
Attached patch Remove FORCE_USE_PIC, v1 (obsolete) — — Splinter Review 
Here is a straightforward patch that removes FORCE_USE_PIC and associated comments from all the Makefile.in's.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #570769 - Flags: review?(khuey)
Comment on attachment 570769 [details] [diff] [review]
Remove FORCE_USE_PIC, v1

I didn't actually verify that these are all of the occurrences in m-c, but this looks good.
Attachment #570769 - Flags: review?(khuey) → review+
Same patch as before. Updated subject line to reflect review. Need checkin.
Attachment #570769 - Attachment is obsolete: true
Attachment #571061 - Flags: review+
Keywords: checkin-needed
I got level 3, so I pushed this to build-system: http://hg.mozilla.org/projects/build-system/rev/e9e6741defd4
Keywords: checkin-needed
Merged to m-c: https://hg.mozilla.org/mozilla-central/rev/e9e6741defd4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Blocks: 892898
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.