Status
People
(Reporter: gps, Assigned: gps)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment, 1 obsolete attachment)
|
32.51 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Unless MXR is letting me down, it appears FORCE_USE_PIC=1 is defined 58 times in 57 files but it isn't being used anywhere. Unless there is a need for it, it should probably be removed from all the Makefiles.
|
||
Comment 1•7 years ago
|
||
Looks like it was bug 648911 that removed the use of this http://hg.mozilla.org/mozilla-central/rev/8e846d7f21ea
Depends on: 648911
|
(Assignee) | |
Comment 2•7 years ago
|
||
Created attachment 570769 [details] [diff] [review] Remove FORCE_USE_PIC, v1 Here is a straightforward patch that removes FORCE_USE_PIC and associated comments from all the Makefile.in's.
Comment on attachment 570769 [details] [diff] [review] Remove FORCE_USE_PIC, v1 I didn't actually verify that these are all of the occurrences in m-c, but this looks good.
Attachment #570769 -
Flags: review?(khuey) → review+
|
|
(Assignee) | |
Comment 4•7 years ago
|
||
Created attachment 571061 [details] [diff] [review] Remove FORCE_USE_PIC, v1 - reviewed Same patch as before. Updated subject line to reflect review. Need checkin.
Attachment #570769 -
Attachment is obsolete: true
Attachment #571061 -
Flags: review+
|
|
(Assignee) | |
Updated•7 years ago
|
Keywords: checkin-needed
|
|
(Assignee) | |
Comment 5•7 years ago
|
||
I got level 3, so I pushed this to build-system: http://hg.mozilla.org/projects/build-system/rev/e9e6741defd4
Keywords: checkin-needed
|
|
(Assignee) | |
Comment 6•7 years ago
|
||
Merged to m-c: https://hg.mozilla.org/mozilla-central/rev/e9e6741defd4
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
|
||
Updated•a year ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•