Last Comment Bug 698249 - Unnecessary nsresult rv declaration in nsFileChannel::OpenContentStream
: Unnecessary nsresult rv declaration in nsFileChannel::OpenContentStream
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: File (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: mozilla10
Assigned To: Alex Vincent [:WeirdAl]
:
: Patrick McManus [:mcmanus]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-29 23:34 PDT by Alex Vincent [:WeirdAl]
Modified: 2011-10-31 11:21 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (954 bytes, patch)
2011-10-29 23:34 PDT, Alex Vincent [:WeirdAl]
bzbarsky: review+
Details | Diff | Splinter Review

Description Alex Vincent [:WeirdAl] 2011-10-29 23:34:46 PDT
Created attachment 570526 [details] [diff] [review]
patch

Near the end of nsFileChannel::OpenContentStream, there's an inner nsresult rv declaration.  We already have an available nsresult rv though, and it's not checked anywhere else.
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2011-10-29 23:50:26 PDT
Comment on attachment 570526 [details] [diff] [review]
patch

r=me
Comment 3 Matt Brubeck (:mbrubeck) 2011-10-31 11:21:24 PDT
https://hg.mozilla.org/mozilla-central/rev/88cd8e9287c8

Note You need to log in before you can comment on or make changes to this bug.