698286 - Bookmark Manager and sidebar completely empty

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Error: PlacesUtils.asContainer(this._places.selectedNode) is null
Source File: chrome://communicator/content/bookmarks/bookmarksManager.js
Line: 65

The above is probably just a symptom; you get no error when just opening the sidebar and activate the Bookmarks panel [the errors that appear when typing there have probably been fixed already for the next nightlies through changeset 0e560a2d28a3]. The Personal Toolbar seems to be unaffected.

Very likely suspects (landed 2011-10-27) affecting Toolkit/Places:
* Bug 696159 - Remove some deprecated Places code
http://hg.mozilla.org/mozilla-central/rev/1ed8be9fed394427989006195532d11c524f5d0d
* Bug 692120 - The star button doesn't need to observe bookmarks changes till bookmarks service is alive.
http://hg.mozilla.org/mozilla-central/rev/1d659cf02d6b2db07a8ddfc7d82d122a28970873

We should probably port both ASAP. Luckily they don't affect l10n so we can fix it on Aurora if we don't make it until the next uplift.

Comment 1

[[e-mail]]

Attachment: Stop using deprecated methods [Checkin: comment 4]

Comment 2

[Hartmut Figge]

(In reply to [e-mail] from comment #1)
> Created attachment 570561 [details] [diff] [review] 

WFM

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 570561 [details] [diff] [review]
Stop using deprecated methods [Checkin: comment 4]

http://hg.mozilla.org/comm-central/rev/391c1e8fc7c3