698303 - [Meta] Mark DOM method arguments optional per the DOM4 spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Arguments which are optional in DOM4 but not in our implementation:

Node.cloneNode(optional boolean deep);  (Note, defaults to true)
Document.createNodeIterator(Node root, optional unsigned long whatToShow,
                            optional NodeFilter? filter);
Document.createTreeWalker(Node root, optional unsigned long whatToShow,
                          optional NodeFilter? filter);

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

The latter two methods used to take also bool aEntityReferenceExpansion as parameter.
We could perhaps make also that optional, or just leave it out.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I think we should just leave it out and make .expandEntityReferences return false.

(We should even make .expandEntityReferences warn if used and then remove it a release later. But that might be a separate bug)

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Actually, we might even be able to remove .expandEntityReferences right away given that it's a property. So we won't throw if people use it, just return a falsy value (undefined).

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Although the changes will be small, I'd prefer making them in separate patches/bugs so that if
some of them isn't web compatible, it can be easily backed out.

Comment 5

[Matthew Schranz [:mjschranz]]

I figure that since I'm working on 698384 and 698385 I might as well go for this one as well, unless someone objects.

Comment 6

[Matthew Schranz [:mjschranz]]

All three of the "sub tickets" 698381 698384 and 698385 are now resolved and have landed.