Closed Bug 698318 Opened 8 years ago Closed 8 years ago

Share Arc to Bezier code used by canvas, and Azure

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Share ArcToBezier (obsolete) — Splinter Review
No description provided.
Attachment #570585 - Flags: review?(jmuizelaar)
Blocks: 687187
Comment on attachment 570585 [details] [diff] [review]
Share ArcToBezier

Review of attachment 570585 [details] [diff] [review]:
-----------------------------------------------------------------

We should probably give Helpers.h a different name. We don't want to encourage people dragging this in everywhere too much :).

::: content/canvas/src/nsCanvasRenderingContext2DAzure.cpp
@@ +121,5 @@
>  #include "gfxWindowsPlatform.h"
>  #endif
>  
>  #ifndef M_PI
>  #define M_PI 3.14159265358979323846

You should define this inside helpers now, not all platforms have this in the global namespace by default.
Comment on attachment 570585 [details] [diff] [review]
Share ArcToBezier

You might want to get Bas to check things over, but I like the direction it's headed.
Attachment #570585 - Flags: review?(jmuizelaar) → review+
Attachment #570585 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c91cf9c721b
Assignee: nobody → matt.woodrow
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/6c91cf9c721b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.