Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Share Arc to Bezier code used by canvas, and Azure

RESOLVED FIXED in mozilla10

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Tracking

unspecified
mozilla10
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 570585 [details] [diff] [review]
Share ArcToBezier
Attachment #570585 - Flags: review?(jmuizelaar)
(Assignee)

Updated

6 years ago
Blocks: 687187
Comment on attachment 570585 [details] [diff] [review]
Share ArcToBezier

Review of attachment 570585 [details] [diff] [review]:
-----------------------------------------------------------------

We should probably give Helpers.h a different name. We don't want to encourage people dragging this in everywhere too much :).

::: content/canvas/src/nsCanvasRenderingContext2DAzure.cpp
@@ +121,5 @@
>  #include "gfxWindowsPlatform.h"
>  #endif
>  
>  #ifndef M_PI
>  #define M_PI 3.14159265358979323846

You should define this inside helpers now, not all platforms have this in the global namespace by default.
Comment on attachment 570585 [details] [diff] [review]
Share ArcToBezier

You might want to get Bas to check things over, but I like the direction it's headed.
Attachment #570585 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 570914 [details] [diff] [review]
Share ArcToBezier code
(Assignee)

Updated

6 years ago
Attachment #570585 - Attachment is obsolete: true
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c91cf9c721b
Assignee: nobody → matt.woodrow
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/6c91cf9c721b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.