Last Comment Bug 698318 - Share Arc to Bezier code used by canvas, and Azure
: Share Arc to Bezier code used by canvas, and Azure
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla10
Assigned To: Matt Woodrow (:mattwoodrow) (PTO until 27 June)
:
Mentors:
Depends on:
Blocks: 687187
  Show dependency treegraph
 
Reported: 2011-10-30 17:56 PDT by Matt Woodrow (:mattwoodrow) (PTO until 27 June)
Modified: 2011-11-03 08:45 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Share ArcToBezier (15.46 KB, patch)
2011-10-30 17:56 PDT, Matt Woodrow (:mattwoodrow) (PTO until 27 June)
jmuizelaar: review+
Details | Diff | Review
Share ArcToBezier code (15.96 KB, patch)
2011-10-31 20:11 PDT, Matt Woodrow (:mattwoodrow) (PTO until 27 June)
no flags Details | Diff | Review

Description Matt Woodrow (:mattwoodrow) (PTO until 27 June) 2011-10-30 17:56:31 PDT
Created attachment 570585 [details] [diff] [review]
Share ArcToBezier
Comment 1 Bas Schouten (:bas.schouten) 2011-10-30 18:29:08 PDT
Comment on attachment 570585 [details] [diff] [review]
Share ArcToBezier

Review of attachment 570585 [details] [diff] [review]:
-----------------------------------------------------------------

We should probably give Helpers.h a different name. We don't want to encourage people dragging this in everywhere too much :).

::: content/canvas/src/nsCanvasRenderingContext2DAzure.cpp
@@ +121,5 @@
>  #include "gfxWindowsPlatform.h"
>  #endif
>  
>  #ifndef M_PI
>  #define M_PI 3.14159265358979323846

You should define this inside helpers now, not all platforms have this in the global namespace by default.
Comment 2 Jeff Muizelaar [:jrmuizel] 2011-10-31 11:37:45 PDT
Comment on attachment 570585 [details] [diff] [review]
Share ArcToBezier

You might want to get Bas to check things over, but I like the direction it's headed.
Comment 3 Matt Woodrow (:mattwoodrow) (PTO until 27 June) 2011-10-31 20:11:54 PDT
Created attachment 570914 [details] [diff] [review]
Share ArcToBezier code
Comment 4 Matt Woodrow (:mattwoodrow) (PTO until 27 June) 2011-11-02 12:56:46 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c91cf9c721b
Comment 5 Marco Bonardo [::mak] 2011-11-03 08:45:20 PDT
https://hg.mozilla.org/mozilla-central/rev/6c91cf9c721b

Note You need to log in before you can comment on or make changes to this bug.