Closed
Bug 698318
Opened 13 years ago
Closed 13 years ago
Share Arc to Bezier code used by canvas, and Azure
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(1 file, 1 obsolete file)
|
15.96 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Attachment #570585 -
Flags: review?(jmuizelaar)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 570585 [details] [diff] [review]
Share ArcToBezier
Review of attachment 570585 [details] [diff] [review]:
-----------------------------------------------------------------
We should probably give Helpers.h a different name. We don't want to encourage people dragging this in everywhere too much :).
::: content/canvas/src/nsCanvasRenderingContext2DAzure.cpp
@@ +121,5 @@
> #include "gfxWindowsPlatform.h"
> #endif
>
> #ifndef M_PI
> #define M_PI 3.14159265358979323846
You should define this inside helpers now, not all platforms have this in the global namespace by default.
|
||
Comment 2•13 years ago
|
||
Comment on attachment 570585 [details] [diff] [review]
Share ArcToBezier
You might want to get Bas to check things over, but I like the direction it's headed.
Attachment #570585 -
Flags: review?(jmuizelaar) → review+
|
Assignee | |
Comment 3•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #570585 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•13 years ago
|
||
Assignee: nobody → matt.woodrow
Whiteboard: [inbound]
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•