Closed Bug 698378 Opened 12 years ago Closed 12 years ago

Give nsIScriptContext::EvaluateStringWithValue a JSObject* scope parameter

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Patch v1
6.45 KB, patch
peterv
: review+
Details | Diff | Splinter Review
Attached patch Patch v1 — — Splinter Review 
      No description provided.
Attachment #570651 - Flags: review?(peterv)
Flags: in-testsuite-
Comment on attachment 570651 [details] [diff] [review]
Patch v1

Review of attachment 570651 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsJSEnvironment.cpp
@@ +1210,5 @@
>    }
>  
> +  if (!aScopeObject) {
> +    aScopeObject = JS_GetGlobalObject(mContext);
> +  }

Could we drop this too? I fund 2 callers and both should pass in an object.
Attachment #570651 - Flags: review?(peterv) → review+
Dropped and added some assertions.

https://hg.mozilla.org/mozilla-central/rev/9124413a73f8
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → mozilla11
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.