Give nsIScriptContext::EvaluateStringWithValue a JSObject* scope parameter

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 570651 [details] [diff] [review]
Patch v1
Attachment #570651 - Flags: review?(peterv)
Flags: in-testsuite-
Comment on attachment 570651 [details] [diff] [review]
Patch v1

Review of attachment 570651 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsJSEnvironment.cpp
@@ +1210,5 @@
>    }
>  
> +  if (!aScopeObject) {
> +    aScopeObject = JS_GetGlobalObject(mContext);
> +  }

Could we drop this too? I fund 2 callers and both should pass in an object.
Attachment #570651 - Flags: review?(peterv) → review+
(Assignee)

Comment 2

6 years ago
Dropped and added some assertions.

https://hg.mozilla.org/mozilla-central/rev/9124413a73f8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.