Last Comment Bug 698386 - Pass JSObject to nsXBLProtoImplMember::CompileMember
: Pass JSObject to nsXBLProtoImplMember::CompileMember
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: 698388
  Show dependency treegraph
 
Reported: 2011-10-31 04:57 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-11-26 07:32 PST (History)
2 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (4.69 KB, patch)
2011-10-31 04:57 PDT, :Ms2ger (⌚ UTC+1/+2)
jonas: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-10-31 04:57:17 PDT
Created attachment 570656 [details] [diff] [review]
Patch v1
Comment 1 Jonas Sicking (:sicking) No longer reading bugmail consistently 2011-11-18 17:09:00 PST
Comment on attachment 570656 [details] [diff] [review]
Patch v1

Don't you also need to remove code that casts aClassObject before using it?
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-11-20 12:02:44 PST
Not in this patch, at least. aClassObject is only passed to nsIScriptContext::CompileFunction, which takes void* until bug 698388.
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2011-11-26 07:32:50 PST
https://hg.mozilla.org/mozilla-central/rev/573c4744a0dd

Note You need to log in before you can comment on or make changes to this bug.