Closed Bug 698389 Opened 9 years ago Closed 9 years ago

Give nsIScriptContext::CompileFunction a JSObject outparam

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #570659 - Flags: review?(peterv)
Comment on attachment 570659 [details] [diff] [review]
Patch v1

Review of attachment 570659 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsJSEnvironment.cpp
@@ +1846,5 @@
>  
> +  JSObject *handler = JS_GetFunctionObject(fun);
> +  if (aFunctionObject) {
> +    *aFunctionObject = handler;
> +  }

Can we disallow passing null for aFunctionObject?
Attachment #570659 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/ddd9b73795f8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.