The default bug view has changed. See this FAQ.

Give nsIScriptContext::CompileFunction a JSObject outparam

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 570659 [details] [diff] [review]
Patch v1
Attachment #570659 - Flags: review?(peterv)
Comment on attachment 570659 [details] [diff] [review]
Patch v1

Review of attachment 570659 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsJSEnvironment.cpp
@@ +1846,5 @@
>  
> +  JSObject *handler = JS_GetFunctionObject(fun);
> +  if (aFunctionObject) {
> +    *aFunctionObject = handler;
> +  }

Can we disallow passing null for aFunctionObject?
Attachment #570659 - Flags: review?(peterv) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ddd9b73795f8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.