Last Comment Bug 698389 - Give nsIScriptContext::CompileFunction a JSObject outparam
: Give nsIScriptContext::CompileFunction a JSObject outparam
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on:
Blocks: 695753
  Show dependency treegraph
 
Reported: 2011-10-31 05:02 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-11-26 07:33 PST (History)
1 user (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (7.12 KB, patch)
2011-10-31 05:02 PDT, :Ms2ger (⌚ UTC+1/+2)
peterv: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-10-31 05:02:22 PDT
Created attachment 570659 [details] [diff] [review]
Patch v1
Comment 1 Peter Van der Beken [:peterv] - away till Aug 1st 2011-11-15 04:31:31 PST
Comment on attachment 570659 [details] [diff] [review]
Patch v1

Review of attachment 570659 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsJSEnvironment.cpp
@@ +1846,5 @@
>  
> +  JSObject *handler = JS_GetFunctionObject(fun);
> +  if (aFunctionObject) {
> +    *aFunctionObject = handler;
> +  }

Can we disallow passing null for aFunctionObject?
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-11-26 07:33:32 PST
https://hg.mozilla.org/mozilla-central/rev/ddd9b73795f8

Note You need to log in before you can comment on or make changes to this bug.