Closed
Bug 698389
Opened 13 years ago
Closed 13 years ago
Give nsIScriptContext::CompileFunction a JSObject outparam
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
|
7.12 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #570659 -
Flags: review?(peterv)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 570659 [details] [diff] [review]
Patch v1
Review of attachment 570659 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/base/nsJSEnvironment.cpp
@@ +1846,5 @@
>
> + JSObject *handler = JS_GetFunctionObject(fun);
> + if (aFunctionObject) {
> + *aFunctionObject = handler;
> + }
Can we disallow passing null for aFunctionObject?
Attachment #570659 -
Flags: review?(peterv) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•