Closed Bug 698436 Opened 8 years ago Closed 8 years ago

Switch to custom spinner


(Firefox for Android :: General, defect, P3)




Tracking Status
firefox11 --- fixed
fennec 11+ ---


(Reporter: kbrosnan, Assigned: sriram)




(4 files, 1 obsolete file)

The spinner is white making it very hard to notice.

HTC Desire S
Android 2.3.5
HTC Sense 3.0

HTC G2 (Desire Z)
Android 2.2
This may be fixed via comment #3 in bug 698042
(In reply to Aaron Train [:aaronmt] from comment #2)
> This may be fixed via comment #3 in bug 698042

Yes it will, so I am morphing this bug
Assignee: nobody → sriram
Summary: spinner is nearly invisible → Switch to custom spinner
Attached file Firefox activity spinner assets (obsolete) —
New assets, with a frame for each stage of the spinner animation
Attachment #571395 - Attachment is obsolete: true
Blocks: 699137
Attached patch PatchSplinter Review
This patch adds a frame animation based spinner to indicate the progress.
The old ProgressBar is replaced with an ImageButton as the ProgressBar didn't provide image scaling options.
This uses two ImageButton's and switches between them based on whether a progress has to be showed or not.

Only one set of images are added as of now. The MDPI versions will be added when the folders for drawables are decided for menus and tabs-list.

One catch with the animation:
The animation cannot start initially when start() is called from onCreate. [] This needs to be called from onWindowFocusChanged().
However, requires not to show the ProgressBar initially. This solves the issue with the animation not starting initially.
Attachment #571480 - Flags: review?(mark.finkle)
This patch uses one ImageButton to show both the favicon and the progress. This is good in terms of number of views that needs to be drawn by android.
Attachment #571489 - Flags: review?(mark.finkle)
Comment on attachment 571489 [details] [diff] [review]
Patch 2: Using one view for favicon/progress

Let's try this approach
Attachment #571489 - Flags: review?(mark.finkle) → review+
Attachment #571480 - Flags: review?(mark.finkle)
Attached file progress_spinner.xml
This had been left out of Patch accidentally.
added the missing file and pushed
Closed: 8 years ago
Resolution: --- → FIXED
Samsung Nexus S (Android 2.3.6)
tracking-fennec: --- → 11+
You need to log in before you can comment on or make changes to this bug.