698436 - Switch to custom spinner

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Kevin Brosnan [Ex-Mozilla]]

The spinner is white making it very hard to notice.

HTC Desire S
Android 2.3.5
HTC Sense 3.0

HTC G2 (Desire Z)
Android 2.2

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Video @ http://people.mozilla.org/~kbrosnan/tmp/698436.webm

Comment 2

[Aaron Train [:aaronmt]]

This may be fixed via comment #3 in bug 698042

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #2)
> This may be fixed via comment #3 in bug 698042

Yes it will, so I am morphing this bug

Comment 4

[Ian Barlow (:ibarlow)]

Attachment: Firefox activity spinner assets

Comment 5

[Ian Barlow (:ibarlow)]

Attachment: Firefox activity spinner assets

New assets, with a frame for each stage of the spinner animation

Comment 6

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch adds a frame animation based spinner to indicate the progress.
The old ProgressBar is replaced with an ImageButton as the ProgressBar didn't provide image scaling options.
This uses two ImageButton's and switches between them based on whether a progress has to be showed or not.

Only one set of images are added as of now. The MDPI versions will be added when the folders for drawables are decided for menus and tabs-list.

One catch with the animation:
The animation cannot start initially when start() is called from onCreate. [http://stackoverflow.com/questions/2785336/starting-frame-by-frame-animation/2790930#2790930] This needs to be called from onWindowFocusChanged().
However, https://bugzilla.mozilla.org/show_bug.cgi?id=699137 requires not to show the ProgressBar initially. This solves the issue with the animation not starting initially.

Comment 7

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch 2: Using one view for favicon/progress

This patch uses one ImageButton to show both the favicon and the progress. This is good in terms of number of views that needs to be drawn by android.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 571489 [details] [diff] [review]
Patch 2: Using one view for favicon/progress

Let's try this approach

Comment 9

[Sriram Ramasubramanian [:sriram]]

Attachment: progress_spinner.xml

This had been left out of Patch accidentally.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

added the missing file and pushed
https://hg.mozilla.org/projects/birch/rev/0571e6fb4b44

Comment 11

[Aaron Train [:aaronmt]]

20111103040334
http://hg.mozilla.org/projects/birch/rev/c09a52af4cd8
Samsung Nexus S (Android 2.3.6)