Status

()

Firefox for Android
General
P3
normal
VERIFIED FIXED
6 years ago
11 months ago

People

(Reporter: kbrosnan, Assigned: sriram)

Tracking

unspecified
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
The spinner is white making it very hard to notice.

HTC Desire S
Android 2.3.5
HTC Sense 3.0

HTC G2 (Desire Z)
Android 2.2
(Reporter)

Comment 1

6 years ago
Video @ http://people.mozilla.org/~kbrosnan/tmp/698436.webm
This may be fixed via comment #3 in bug 698042
(In reply to Aaron Train [:aaronmt] from comment #2)
> This may be fixed via comment #3 in bug 698042

Yes it will, so I am morphing this bug
Assignee: nobody → sriram
Summary: spinner is nearly invisible → Switch to custom spinner
Created attachment 571395 [details]
Firefox activity spinner assets
Created attachment 571433 [details]
Firefox activity spinner assets

New assets, with a frame for each stage of the spinner animation
Attachment #571395 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Blocks: 699137
(Assignee)

Comment 6

6 years ago
Created attachment 571480 [details] [diff] [review]
Patch

This patch adds a frame animation based spinner to indicate the progress.
The old ProgressBar is replaced with an ImageButton as the ProgressBar didn't provide image scaling options.
This uses two ImageButton's and switches between them based on whether a progress has to be showed or not.

Only one set of images are added as of now. The MDPI versions will be added when the folders for drawables are decided for menus and tabs-list.

One catch with the animation:
The animation cannot start initially when start() is called from onCreate. [http://stackoverflow.com/questions/2785336/starting-frame-by-frame-animation/2790930#2790930] This needs to be called from onWindowFocusChanged().
However, https://bugzilla.mozilla.org/show_bug.cgi?id=699137 requires not to show the ProgressBar initially. This solves the issue with the animation not starting initially.
Attachment #571480 - Flags: review?(mark.finkle)
(Assignee)

Comment 7

6 years ago
Created attachment 571489 [details] [diff] [review]
Patch 2: Using one view for favicon/progress

This patch uses one ImageButton to show both the favicon and the progress. This is good in terms of number of views that needs to be drawn by android.
Attachment #571489 - Flags: review?(mark.finkle)
Comment on attachment 571489 [details] [diff] [review]
Patch 2: Using one view for favicon/progress

Let's try this approach
Attachment #571489 - Flags: review?(mark.finkle) → review+
Attachment #571480 - Flags: review?(mark.finkle)
(Assignee)

Comment 9

6 years ago
Created attachment 571529 [details]
progress_spinner.xml

This had been left out of Patch accidentally.
added the missing file and pushed
https://hg.mozilla.org/projects/birch/rev/0571e6fb4b44
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
20111103040334
http://hg.mozilla.org/projects/birch/rev/c09a52af4cd8
Samsung Nexus S (Android 2.3.6)
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.