698440 - IndexedDB: Implement optional version syntax.

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The tests here look a bit lacking. Is it really testing that opening an existing database opens it with the database's existing version and objectStores, and that if there exists no database, a new one is created with version 1?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

It's not testing anything with objectStores, but it is testing the version bits.

Adding more tests isn't hard.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 570711 [details] [diff] [review]
Patch

Review of attachment 570711 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IDBFactory.cpp
@@ +380,5 @@
>  NS_IMETHODIMP
>  IDBFactory::Open(const nsAString& aName,
>                   PRInt64 aVersion,
>                   JSContext* aCx,
> +                 PRUint8 aArgc,

Nit: This isn't argc, it's the number of optional args passed. Call it 'aOptionalArgCount'

::: dom/indexedDB/OpenDatabaseHelper.cpp
@@ +753,5 @@
> +    // treat it as if version 1 were requested.
> +    if (mCurrentVersion == 0) {
> +      mRequestedVersion = 1;
> +    }
> +    // Otherwise, treat it as if the current version were requested.

Nit: move this comment inside the else block.

::: dom/indexedDB/nsIIDBFactory.idl
@@ +56,2 @@
>    nsIIDBOpenDBRequest
> +  open(in AString name, [optional] in long long version);

Nit: Each arg gets its own line.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80af665378fd

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/80af665378fd

Comment 6

[Chris Mills [:cmills]]

Already documented, see

https://developer.mozilla.org/en-US/docs/Web/API/IDBFactory/open

note added to 

https://developer.mozilla.org/en-US/Firefox/Releases/10#IndexedDB