Created attachment 570784 [details] [diff] [review]
Created attachment 570802 [details] [diff] [review]
Looks like other things were broken.
Wouldn't we be better just removing the MOZ_SMIL defines and having SMIL in the build always.
(In reply to Robert Longson from comment #2)
> Wouldn't we be better just removing the MOZ_SMIL defines and having SMIL in
> the build always.
Most of my dev builds have --disable-smil and I didn't get that many issues with SMIL. Actually, it's been a long time since I got any build issues because of my disabled options.
However, if the reasons why this option exist doesn't apply anymore, I would be fine with removing it. Though, can we fix that bug first? :)
Comment on attachment 570802 [details] [diff] [review]
Looks good. Sorry for not having caught this in review on bug 693145.
I'll file a separate bug on removing MOZ_SMIL #ifdefs.
(Filed bug 698630 on removing the --disable-smil option)
volkmar landed this as:
Removing [inbound] per https://wiki.mozilla.org/Tree_Rules/Inbound