The default bug view has changed. See this FAQ.

Build fails when smil is disabled

RESOLVED FIXED in mozilla10

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla10
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 570784 [details] [diff] [review]
Patch
Attachment #570784 - Flags: review?(dholbert)
Attachment #570784 - Flags: review?(dholbert) → review+
Blocks: 693145
(Assignee)

Comment 1

6 years ago
Created attachment 570802 [details] [diff] [review]
Patch v2

Looks like other things were broken.
Attachment #570784 - Attachment is obsolete: true
Attachment #570802 - Flags: review?(dholbert)

Comment 2

6 years ago
Wouldn't we be better just removing the MOZ_SMIL defines and having SMIL in the build always.
(Assignee)

Comment 3

6 years ago
(In reply to Robert Longson from comment #2)
> Wouldn't we be better just removing the MOZ_SMIL defines and having SMIL in
> the build always.

Most of my dev builds have --disable-smil and I didn't get that many issues with SMIL. Actually, it's been a long time since I got any build issues because of my disabled options.

However, if the reasons why this option exist doesn't apply anymore, I would be fine with removing it. Though, can we fix that bug first? :)
Comment on attachment 570802 [details] [diff] [review]
Patch v2

Looks good.  Sorry for not having caught this in review on bug 693145.

I'll file a separate bug on removing MOZ_SMIL #ifdefs.
Attachment #570802 - Flags: review?(dholbert) → review+
(Filed bug 698630 on removing the --disable-smil option)
(Assignee)

Updated

6 years ago
Flags: in-testsuite-
Whiteboard: [needs review] → [inbound]
volkmar landed this as:
http://hg.mozilla.org/integration/mozilla-inbound/rev/b2c58afeead0

Removing [inbound] per https://wiki.mozilla.org/Tree_Rules/Inbound
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/b2c58afeead0
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.