Closed Bug 698534 Opened 8 years ago Closed 8 years ago
Build fails when smil is disabled
No description provided.
Attachment #570784 - Flags: review?(dholbert)
8 years ago
Attachment #570784 - Flags: review?(dholbert) → review+
8 years ago
Looks like other things were broken.
Wouldn't we be better just removing the MOZ_SMIL defines and having SMIL in the build always.
(In reply to Robert Longson from comment #2) > Wouldn't we be better just removing the MOZ_SMIL defines and having SMIL in > the build always. Most of my dev builds have --disable-smil and I didn't get that many issues with SMIL. Actually, it's been a long time since I got any build issues because of my disabled options. However, if the reasons why this option exist doesn't apply anymore, I would be fine with removing it. Though, can we fix that bug first? :)
Comment on attachment 570802 [details] [diff] [review] Patch v2 Looks good. Sorry for not having caught this in review on bug 693145. I'll file a separate bug on removing MOZ_SMIL #ifdefs.
Attachment #570802 - Flags: review?(dholbert) → review+
(Filed bug 698630 on removing the --disable-smil option)
Whiteboard: [needs review] → [inbound]
volkmar landed this as: http://hg.mozilla.org/integration/mozilla-inbound/rev/b2c58afeead0 Removing [inbound] per https://wiki.mozilla.org/Tree_Rules/Inbound
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.