Closed Bug 698534 Opened 14 years ago Closed 14 years ago

Build fails when smil is disabled

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
No description provided.
Attachment #570784 - Flags: review?(dholbert)
Attachment #570784 - Flags: review?(dholbert) → review+
Blocks: 693145
Attached patch Patch v2Splinter Review
Looks like other things were broken.
Attachment #570784 - Attachment is obsolete: true
Attachment #570802 - Flags: review?(dholbert)
Wouldn't we be better just removing the MOZ_SMIL defines and having SMIL in the build always.
(In reply to Robert Longson from comment #2) > Wouldn't we be better just removing the MOZ_SMIL defines and having SMIL in > the build always. Most of my dev builds have --disable-smil and I didn't get that many issues with SMIL. Actually, it's been a long time since I got any build issues because of my disabled options. However, if the reasons why this option exist doesn't apply anymore, I would be fine with removing it. Though, can we fix that bug first? :)
Comment on attachment 570802 [details] [diff] [review] Patch v2 Looks good. Sorry for not having caught this in review on bug 693145. I'll file a separate bug on removing MOZ_SMIL #ifdefs.
Attachment #570802 - Flags: review?(dholbert) → review+
(Filed bug 698630 on removing the --disable-smil option)
Flags: in-testsuite-
Whiteboard: [needs review] → [inbound]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: