Closed
Bug 698563
Opened 13 years ago
Closed 13 years ago
IonMonkey: rather than generating nothing, generateArgumentsRectifier should generate an ArgumentsRectifier.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mjrosenb, Unassigned)
Details
Attachments
(1 file)
11.82 KB,
patch
|
jbramley
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•13 years ago
|
||
This was a pretty straightforward translation of the x64 variant.
Attachment #573289 -
Flags: review?(Jacob.Bramley)
Comment 2•13 years ago
|
||
Comment on attachment 573289 [details] [diff] [review] Write the body of the arguments rectifier. Review of attachment 573289 [details] [diff] [review]: ----------------------------------------------------------------- One niggle to be addressed, but otherwise good. ::: js/src/ion/arm/MacroAssembler-arm.cpp @@ +704,5 @@ > Index mode, Assembler::Condition cc) > { > + int x = offset.value; > + // we can encode this as a standard ldr... MAKE IT SO > + if (size == 32 || size == 8 && !IsSigned ) { That would be clearer with brackets: if (size == 32 || (size == 8 && !IsSigned)) (I had to look up the || versus && precedence to check it was correct.) ::: js/src/ion/arm/Trampoline-arm.cpp @@ +219,2 @@ > > + masm.ma_add(r3, lsl(r8, 3), r3); // r3 <- r3 + nargs * 8 Ooh, that is elegant. I like it :-)
Attachment #573289 -
Flags: review?(Jacob.Bramley) → review+
Reporter | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•