Closed
Bug 69859
Opened 24 years ago
Closed 23 years ago
The NS_OpenURI that returns a nsIChannel is incorrectly named
Categories
(Core :: Networking, defect, P5)
Core
Networking
Tracking
()
VERIFIED
FIXED
mozilla1.0
People
(Reporter: darin.moz, Assigned: darin.moz)
References
Details
(Keywords: topembed)
nsNetUtil.h defines 3 versions of NS_OpenURI. The first returns an unopened
channel, while the latter two call either Open or AsyncOpen to actually open
the channel. Overloading the function name NS_OpenURI like this is very
confusing.
Opening a URI means opening the channel corresponding to the URI, so NS_OpenURI
should be renamed to something like NS_NewChannel or NS_NewChannelFromURI in
the case that returns a nsIChannel.
The old method would remain (for backwards compatibility), but we should mark
it as depracated and possibly insert a debug warning.
|
Assignee | |
Comment 1•24 years ago
|
||
added keyword nsbeta1
Keywords: nsbeta1
Target Milestone: --- → mozilla0.9
|
|
Assignee | |
Updated•24 years ago
|
Target Milestone: mozilla0.9 → mozilla0.9.1
|
|
Assignee | |
Updated•23 years ago
|
Target Milestone: mozilla0.9.2 → mozilla1.0
|
|
Assignee | |
Updated•23 years ago
|
|
|
Assignee | |
Updated•23 years ago
|
|
|
Assignee | |
Comment 4•23 years ago
|
||
my patch for bug 124042 includes the fix for this.
Depends on: 124042
|
|
Assignee | |
Comment 5•23 years ago
|
||
fixed-on-trunk now that bug 124042 has been fixed on the trunk.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
VERIFIED:
poking around w/ LXR, I see there are currently two NS_OpenURI, as well as a
change in CVS that renamed the 3rd.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•