698590 - images with fractional opacity are positioned outside container when page is zoomed

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Matthew N. [:MattN]]

Attachment: Actual Result: Screenshot of toolbar with images positioned outside container

Since the nightly build on 2011-10-27, the toolbar images on Google Voice are positioned outside of their containing <div> when the page is zoomed in.  See screenshot of the problem.

STR:
1) Load https://www.google.com/voice and login/create an account (sorry, U.S only)
2) Zoom in on the page

Actual result:
some button images are positioned outside the container <div>

Expected result:
button image zooms but stays within the <div>

Last good nightly: 10.0a1 (2011-10-26)
Built from http://hg.mozilla.org/mozilla-central/rev/cc66accc8181

First bad nightly:
Built from http://hg.mozilla.org/mozilla-central/rev/4bb7c983d589

Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cc66accc8181&tochange=4bb7c983d589

Comment 1

[Matthew N. [:MattN]]

Attachment: testcase: <img> with opacity position incorrect after zoom

This seems to be a problem with positioning the img if there is opacity specified on the <img> and the page is zoomed. Not sure if it's a gfx or layout bug.

Comment 2

[Alice0775 White]

Regression window(m-i)
Works:
http://hg.mozilla.org/integration/mozilla-inbound/rev/98013fe19dcb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111025 Firefox/10.0a1 ID:20111025195747
Fails:
http://hg.mozilla.org/integration/mozilla-inbound/rev/d7f3bfc7cd46
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111025 Firefox/10.0a1 ID:20111025203245
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=98013fe19dcb&tochange=d7f3bfc7cd46
Triggered by:
8b89d7037306	Matt Woodrow — Bug 695275 - Fix conversion of ThebesLayers to ImageLayers. r=roc

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

devpixels/CSSpixels confusion presumably

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Make ConfigureLayer use DevPixels instead of AppPixels.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 571447 [details] [diff] [review]
Make ConfigureLayer use DevPixels instead of AppPixels.

Review of attachment 571447 [details] [diff] [review]:
-----------------------------------------------------------------

Reftest?

Comment 8

[Matt Woodrow (:mattwoodrow)]

Landed this as https://hg.mozilla.org/integration/mozilla-inbound/rev/95efc21bf5af to try make the next aurora merge.

Will get a reftest added asap, please leave bug open.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/95efc21bf5af

(Leaving open for retest, per comment 8)

Comment 10

[Bryan Price]

Today's nightly is actually worse for Gvoice/Greader (especially Greader, it's broke even without any zoom...)

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Does that build have this fix?

Comment 12

[Michał]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #11)
> Does that build have this fix?
I think it will be in next Nightly (09-11-2011), beacause now I can't see any difference.

Comment 13

[Bryan Price]

Google fixed the issue I was having(as long as you don't zoom).  Weird.

Comment 14

[Drew Noel]

I can confirm that it is fixed in my Nightly.

Mozilla/5.0 (Windows NT 6.1; rv:11.0a1) Gecko/20111109 Firefox/11.0a1 ID:20111109031111

Comment 15

[Alex Keybl [:akeybl]]

Doesn't occur on FF10 for me, even with zooming.

Comment 16

[Matt Woodrow (:mattwoodrow)]

Attachment: Add reftest for zoomed ImageLayer

Comment 17

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d36479d1250

Comment 18

[Matt Brubeck (:mbrubeck)]

Reftest landed in mozilla11:
https://hg.mozilla.org/mozilla-central/rev/6d36479d1250