Closed
Bug 698614
Opened 15 years ago
Closed 15 years ago
Give run_tests.py a real main() function
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
Details
Attachments
(1 file)
|
3.30 KB,
patch
|
wlach
:
review+
jmaher
:
feedback+
|
Details | Diff | Splinter Review |
Currently, run_tests.py runs from a `if __name__ == '__main__':`
clause. It should have a main() function that can be used as a command
line entry point (once the various file path issues are sorted out).
It also uses getopt, which should be replaced with optparse.
| Reporter | ||
Comment 1•15 years ago
|
||
This also cleans up shortName to use a dictionary instead of an if-else tree
Attachment #570868 -
Flags: review?(wlachance)
Attachment #570868 -
Flags: feedback?(jmaher)
Comment 2•15 years ago
|
||
Comment on attachment 570868 [details] [diff] [review]
add a main() function
+ # set variables
+ if options.debug:
+ print 'setting debug'
I think we can lose this line. :)
Other than that, I love this patch.
Attachment #570868 -
Flags: review?(wlachance) → review+
| Reporter | ||
Comment 3•15 years ago
|
||
FWIW, I only did the print because it was already there, but I am in favor of losing it (and will do so before checkin.
| Reporter | ||
Comment 4•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Attachment #570868 -
Flags: feedback?(jmaher) → feedback+
You need to log in
before you can comment on or make changes to this bug.
Description
•