698656 - mParent pointer should not be in nsSHEntryShared

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Justin Lebar (not reading bugmail)]

whoaboy, this is bad.

Comment 1

[Justin Lebar (not reading bugmail)]

The problem here is illustrated in bug 687710 comment 41.

Comment 2

[Justin Lebar (not reading bugmail)]

Attachment: Patch v1

I thought about writing a test for this, but I'm not sure if there are web-visible effects of this change.  It depends on who reads the parent SHEntry's URI, I guess...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 570910 [details] [diff] [review]
Patch v1

Please fix the copy constructor too.  It needs to copy mParent, right?

r=me with that.

Comment 4

[Justin Lebar (not reading bugmail)]

Thanks.

Inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/65ffdabf1b6b

Comment 5

[Boris Zbarsky [:bzbarsky]]

What about the copy constructor?  See comment 3!

Comment 6

[Justin Lebar (not reading bugmail)]

I fixed it!  But then I didn't qref, and I pushed my patch to my inbound tree...ack.

Comment 7

[Justin Lebar (not reading bugmail)]

Hopefully with less orange: https://hg.mozilla.org/integration/mozilla-inbound/rev/f3babd4e975f

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/f3babd4e975f