Last Comment Bug 698656 - mParent pointer should not be in nsSHEntryShared
: mParent pointer should not be in nsSHEntryShared
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla10
Assigned To: Justin Lebar (not reading bugmail)
:
Mentors:
Depends on:
Blocks: 646641
  Show dependency treegraph
 
Reported: 2011-10-31 19:05 PDT by Justin Lebar (not reading bugmail)
Modified: 2011-11-01 07:42 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (4.73 KB, patch)
2011-10-31 19:16 PDT, Justin Lebar (not reading bugmail)
bzbarsky: review+
Details | Diff | Splinter Review

Description Justin Lebar (not reading bugmail) 2011-10-31 19:05:46 PDT
whoaboy, this is bad.
Comment 1 Justin Lebar (not reading bugmail) 2011-10-31 19:08:34 PDT
The problem here is illustrated in bug 687710 comment 41.
Comment 2 Justin Lebar (not reading bugmail) 2011-10-31 19:16:50 PDT
Created attachment 570910 [details] [diff] [review]
Patch v1

I thought about writing a test for this, but I'm not sure if there are web-visible effects of this change.  It depends on who reads the parent SHEntry's URI, I guess...
Comment 3 Boris Zbarsky [:bz] 2011-10-31 19:24:05 PDT
Comment on attachment 570910 [details] [diff] [review]
Patch v1

Please fix the copy constructor too.  It needs to copy mParent, right?

r=me with that.
Comment 4 Justin Lebar (not reading bugmail) 2011-10-31 19:34:45 PDT
Thanks.

Inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/65ffdabf1b6b
Comment 5 Boris Zbarsky [:bz] 2011-10-31 19:53:23 PDT
What about the copy constructor?  See comment 3!
Comment 6 Justin Lebar (not reading bugmail) 2011-10-31 19:56:41 PDT
I fixed it!  But then I didn't qref, and I pushed my patch to my inbound tree...ack.
Comment 7 Justin Lebar (not reading bugmail) 2011-10-31 20:15:16 PDT
Hopefully with less orange: https://hg.mozilla.org/integration/mozilla-inbound/rev/f3babd4e975f
Comment 8 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-11-01 07:42:00 PDT
https://hg.mozilla.org/mozilla-central/rev/f3babd4e975f

Note You need to log in before you can comment on or make changes to this bug.