mParent pointer should not be in nsSHEntryShared

RESOLVED FIXED in mozilla10

Status

()

Core
Document Navigation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

unspecified
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
whoaboy, this is bad.
(Assignee)

Updated

6 years ago
Blocks: 646641
(Assignee)

Comment 1

6 years ago
The problem here is illustrated in bug 687710 comment 41.
(Assignee)

Comment 2

6 years ago
Created attachment 570910 [details] [diff] [review]
Patch v1

I thought about writing a test for this, but I'm not sure if there are web-visible effects of this change.  It depends on who reads the parent SHEntry's URI, I guess...
(Assignee)

Updated

6 years ago
Attachment #570910 - Flags: review?(bzbarsky)
Comment on attachment 570910 [details] [diff] [review]
Patch v1

Please fix the copy constructor too.  It needs to copy mParent, right?

r=me with that.
Attachment #570910 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 4

6 years ago
Thanks.

Inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/65ffdabf1b6b
Whiteboard: [inbound]
What about the copy constructor?  See comment 3!
(Assignee)

Comment 6

6 years ago
I fixed it!  But then I didn't qref, and I pushed my patch to my inbound tree...ack.
(Assignee)

Comment 7

6 years ago
Hopefully with less orange: https://hg.mozilla.org/integration/mozilla-inbound/rev/f3babd4e975f
https://hg.mozilla.org/mozilla-central/rev/f3babd4e975f
Assignee: nobody → justin.lebar+bug
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.