Last Comment Bug 698703 - Source Editor should display text with the user's preferred monospace font size
: Source Editor should display text with the user's preferred monospace font size
Status: RESOLVED FIXED
[sourceeditor][orion]
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 10
Assigned To: Cedric Vivier [:cedricv]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-01 03:35 PDT by Cedric Vivier [:cedricv]
Modified: 2011-11-02 03:03 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use preferred monospace font size (1020 bytes, patch)
2011-11-01 03:39 PDT, Cedric Vivier [:cedricv]
mihai.sucan: review+
Details | Diff | Splinter Review
v2, removed .rulerTooltip that got removed in recent Orion update (1014 bytes, patch)
2011-11-01 04:08 PDT, Cedric Vivier [:cedricv]
cedricv: review+
Details | Diff | Splinter Review

Description Cedric Vivier [:cedricv] 2011-11-01 03:35:22 PDT
SourceEditor currently uses a fixed size of 10pt on all platforms.
It should probably rather use the user's preferred monospace font size (Preferences -> Content -> Fonts).

It also helps to integrate SourceEditor with other browser UI.
Comment 1 Cedric Vivier [:cedricv] 2011-11-01 03:39:43 PDT
Created attachment 570954 [details] [diff] [review]
Use preferred monospace font size
Comment 2 Mihai Sucan [:msucan] 2011-11-01 03:51:25 PDT
Comment on attachment 570954 [details] [diff] [review]
Use preferred monospace font size

Review of attachment 570954 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for your patch. r+ with the comment below addressed.

(please rebase on top of the latest fx-team. thanks!)

::: browser/devtools/sourceeditor/orion/mozilla.css
@@ +1,5 @@
>  /* Any copyright is dedicated to the Public Domain.
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +.viewContainer,
> +.rulerTooltip {

.rulerTooltip is unused.

The ruler copies the styling of .viewContainer, so just setting font-size: inherit for .viewContainer is sufficient.
Comment 3 Cedric Vivier [:cedricv] 2011-11-01 04:08:05 PDT
Created attachment 570961 [details] [diff] [review]
v2, removed .rulerTooltip that got removed in recent Orion update
Comment 4 Dão Gottwald [:dao] 2011-11-01 09:14:24 PDT
Comment on attachment 570961 [details] [diff] [review]
v2, removed .rulerTooltip that got removed in recent Orion update

>+	font-size: inherit; /* inherit browser's default monospace font size */

Replace the tab with two spaces.
Comment 5 Rob Campbell [:rc] (:robcee) 2011-11-01 10:38:45 PDT
https://hg.mozilla.org/integration/fx-team/rev/f5bc569a7c01

(with dão's suggestion from c#4)
Comment 6 Tim Taubert [:ttaubert] 2011-11-02 03:03:27 PDT
https://hg.mozilla.org/mozilla-central/rev/f5bc569a7c01

Note You need to log in before you can comment on or make changes to this bug.