Source Editor should display text with the user's preferred monospace font size

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: cedricv, Assigned: cedricv)

Tracking

unspecified
Firefox 10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sourceeditor][orion])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
SourceEditor currently uses a fixed size of 10pt on all platforms.
It should probably rather use the user's preferred monospace font size (Preferences -> Content -> Fonts).

It also helps to integrate SourceEditor with other browser UI.
(Assignee)

Updated

6 years ago
Summary: SourcEditor should respect user's preferred monospace font size → SourcEditor should display text with the user's preferred monospace font size

Updated

6 years ago
Summary: SourcEditor should display text with the user's preferred monospace font size → Source Editor should display text with the user's preferred monospace font size
Whiteboard: [sourceeditor][orion]
(Assignee)

Comment 1

6 years ago
Created attachment 570954 [details] [diff] [review]
Use preferred monospace font size
Attachment #570954 - Flags: review?(mihai.sucan)
Comment on attachment 570954 [details] [diff] [review]
Use preferred monospace font size

Review of attachment 570954 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for your patch. r+ with the comment below addressed.

(please rebase on top of the latest fx-team. thanks!)

::: browser/devtools/sourceeditor/orion/mozilla.css
@@ +1,5 @@
>  /* Any copyright is dedicated to the Public Domain.
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +.viewContainer,
> +.rulerTooltip {

.rulerTooltip is unused.

The ruler copies the styling of .viewContainer, so just setting font-size: inherit for .viewContainer is sufficient.
Attachment #570954 - Flags: review?(mihai.sucan) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 570961 [details] [diff] [review]
v2, removed .rulerTooltip that got removed in recent Orion update
Attachment #570954 - Attachment is obsolete: true
Attachment #570961 - Flags: review+

Updated

6 years ago
Whiteboard: [sourceeditor][orion] → [sourceeditor][orion][land-in-fx-team]
Comment on attachment 570961 [details] [diff] [review]
v2, removed .rulerTooltip that got removed in recent Orion update

>+	font-size: inherit; /* inherit browser's default monospace font size */

Replace the tab with two spaces.
https://hg.mozilla.org/integration/fx-team/rev/f5bc569a7c01

(with dão's suggestion from c#4)
Whiteboard: [sourceeditor][orion][land-in-fx-team] → [sourceeditor][orion][fixed-in-fx-team]
Target Milestone: --- → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/f5bc569a7c01
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [sourceeditor][orion][fixed-in-fx-team] → [sourceeditor][orion]
You need to log in before you can comment on or make changes to this bug.