69873 - get rid of |nsAutoCString|

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Scott Collins]

This class (which _looks_ like |nsCAutoString|) has never really been part of
the string hierarchy.  It acts much like |nsXPIDLCString|.  We need to get rid
of it.  It mostly appears in relation with |nsFileSpec| another class that is
supposed to go away.

Comment 1

[Scott Collins]

secondary api issue

Comment 2

[Scott Collins]

re-targeting milestones, starting from a clean slate

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Taking.  Patch coming, once it compiles.  (BTW, it looks more like
NS_LossyConvertUCS2toASCII than anything else, except that it heap-allocates.)

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch (still compiling in my build)

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Since attaching the patch I fixed the indentation of what I added in
nsFileSpecMac.cpp to the proper combination of tabs and spaces that works at any
tab setting and I changed the ToNewCString in nsInstall.cpp to an nsCRT::strdup.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: working patch

Comment 7

[jag (Peter Annema)]

Comment on attachment 53119 [details] [diff] [review]
working patch

r=jag

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Checked in 2001-10-11 19:57/58 PDT.

Comment 9

[Mrten]

could this patch cause bug 108350?