get rid of |nsAutoCString|

RESOLVED FIXED

Status

()

Core
String
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: Scott Collins, Assigned: dbaron)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
This class (which _looks_ like |nsCAutoString|) has never really been part of
the string hierarchy.  It acts much like |nsXPIDLCString|.  We need to get rid
of it.  It mostly appears in relation with |nsFileSpec| another class that is
supposed to go away.
(Reporter)

Updated

17 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
(Reporter)

Updated

17 years ago
Blocks: 28221
(Reporter)

Updated

17 years ago
Blocks: 53065
No longer blocks: 28221
(Reporter)

Updated

17 years ago
No longer blocks: 53065
(Reporter)

Updated

17 years ago
Depends on: 53065
(Reporter)

Updated

17 years ago
Blocks: 28221
(Reporter)

Updated

17 years ago
Target Milestone: mozilla0.9.1 → mozilla0.9
(Reporter)

Comment 1

17 years ago
secondary api issue
Blocks: 73009
No longer blocks: 28221
Target Milestone: mozilla0.9 → mozilla1.1
(Reporter)

Comment 2

17 years ago
re-targeting milestones, starting from a clean slate
Target Milestone: mozilla1.1 → ---
(Assignee)

Comment 3

17 years ago
Taking.  Patch coming, once it compiles.  (BTW, it looks more like
NS_LossyConvertUCS2toASCII than anything else, except that it heap-allocates.)
Assignee: scc → dbaron
Status: ASSIGNED → NEW
(Assignee)

Comment 4

17 years ago
Created attachment 53065 [details] [diff] [review]
patch (still compiling in my build)
(Assignee)

Comment 5

17 years ago
Since attaching the patch I fixed the indentation of what I added in
nsFileSpecMac.cpp to the proper combination of tabs and spaces that works at any
tab setting and I changed the ToNewCString in nsInstall.cpp to an nsCRT::strdup.
(Assignee)

Comment 6

17 years ago
Created attachment 53119 [details] [diff] [review]
working patch

Comment 7

17 years ago
Comment on attachment 53119 [details] [diff] [review]
working patch

r=jag
Attachment #53119 - Flags: review+
(Assignee)

Comment 8

17 years ago
Checked in 2001-10-11 19:57/58 PDT.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 9

17 years ago
could this patch cause bug 108350?

You need to log in before you can comment on or make changes to this bug.