Closed
Bug 69873
Opened 24 years ago
Closed 23 years ago
get rid of |nsAutoCString|
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: scc, Assigned: dbaron)
References
()
Details
Attachments
(2 files)
32.97 KB,
patch
|
Details | Diff | Splinter Review | |
33.60 KB,
patch
|
jag+mozilla
:
review+
|
Details | Diff | Splinter Review |
This class (which _looks_ like |nsCAutoString|) has never really been part of the string hierarchy. It acts much like |nsXPIDLCString|. We need to get rid of it. It mostly appears in relation with |nsFileSpec| another class that is supposed to go away.
Reporter | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
Reporter | ||
Updated•24 years ago
|
Reporter | ||
Updated•24 years ago
|
Target Milestone: mozilla0.9.1 → mozilla0.9
Reporter | ||
Comment 1•23 years ago
|
||
secondary api issue
Reporter | ||
Comment 2•23 years ago
|
||
re-targeting milestones, starting from a clean slate
Target Milestone: mozilla1.1 → ---
Assignee | ||
Updated•23 years ago
|
Assignee | ||
Comment 3•23 years ago
|
||
Taking. Patch coming, once it compiles. (BTW, it looks more like NS_LossyConvertUCS2toASCII than anything else, except that it heap-allocates.)
Assignee: scc → dbaron
Status: ASSIGNED → NEW
Assignee | ||
Comment 4•23 years ago
|
||
Assignee | ||
Comment 5•23 years ago
|
||
Since attaching the patch I fixed the indentation of what I added in nsFileSpecMac.cpp to the proper combination of tabs and spaces that works at any tab setting and I changed the ToNewCString in nsInstall.cpp to an nsCRT::strdup.
Assignee | ||
Comment 6•23 years ago
|
||
Comment 7•23 years ago
|
||
Comment on attachment 53119 [details] [diff] [review] working patch r=jag
Attachment #53119 -
Flags: review+
Assignee | ||
Comment 8•23 years ago
|
||
Checked in 2001-10-11 19:57/58 PDT.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
could this patch cause bug 108350?
Updated•3 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•