698856 - Upgrade WebGL conformance test suite to r15981

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

https://tbpl.mozilla.org/?tree=Try&rev=77d835cc986a

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

https://tbpl.mozilla.org/?tree=Try&rev=d46689b01860

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/be8056caccb4

The only nontrivial change is that the garbageCollect call is now done on all platforms, instead of only linux. Clear from the purples on https://tbpl.mozilla.org/?tree=Try&rev=d46689b01860 . Added this comment:

    // Calling garbageCollect before each test page fixes intermittent failures with
    // out-of-memory errors, often failing to create a WebGL context.
    // The explanation is that the JS engine keeps unreferenced WebGL contexts around
    // for too long before GCing (bug 617453), so that during this mochitest dozens of unreferenced
    // WebGL contexts can accumulate at a given time.
    SpecialPowers.DOMWindowUtils.garbageCollect();

Comment 3

[Ed Morley [:emorley]]

M1 orange on this push:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=be8056caccb4

Presume it just needs the test annotation changing to reflect the test is now passing.

Comment 4

[Matt Brubeck (:mbrubeck)]

Backed out on inbound for now:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c55634fffb6

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

indeed, that test had to be removed from failing_tests_*.txt.

http://hg.mozilla.org/integration/mozilla-inbound/rev/866c4e972918

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

Followup removing one test from the windows failures list:
http://hg.mozilla.org/integration/mozilla-inbound/rev/cedae68ef0e2

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/866c4e972918
https://hg.mozilla.org/mozilla-central/rev/cedae68ef0e2