698923 - MethodJIT.cpp:263:1: error: size of array ‘js_static_assert98’ is negative

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Mike Hommey [:glandium]]

Current mozilla-central fails to build with the following error:
js/src/methodjit/MethodJIT.cpp: At global scope:
js/src/methodjit/MethodJIT.cpp:263:1: error: size of array ‘js_static_assert98’ is negative

This is because VMFrame size is not a multiple of 16.

Comment 1

[Ginn Chen]

Are you using Linux or Solaris?

Comment 2

[Mike Hommey [:glandium]]

Linux, but it doesn't look like this would be OS specific.

Comment 3

[Leon Sha]

VMFRAME do not need 16bytes align. Try this patch.

diff -r 879d466adbe0 js/src/methodjit/MethodJIT.cpp                             
--- a/js/src/methodjit/MethodJIT.cpp    Mon Nov 14 13:03:50 2011 -0800          
+++ b/js/src/methodjit/MethodJIT.cpp    Wed Nov 16 07:08:16 2011 +0800          
@@ -257,7 +257,7 @@                                                             
 #if defined(__GNUC__) && !defined(_WIN64)                                      
                                                                                
 /* If this assert fails, you need to realign VMFrame to 16 bytes. */           
-#ifdef JS_CPU_ARM                                                              
+#if defined(JS_CPU_ARM) || defined(JS_CPU_SPARC)                               
 JS_STATIC_ASSERT(sizeof(VMFrame) % 8 == 0);                                    
 #else                                                                          
 JS_STATIC_ASSERT(sizeof(VMFrame) % 16 == 0);

Comment 4

[Mike Hommey [:glandium]]

(In reply to Leon Sha from comment #3)
> VMFRAME do not need 16bytes align. Try this patch.
> 
> diff -r 879d466adbe0 js/src/methodjit/MethodJIT.cpp                         
> 
> --- a/js/src/methodjit/MethodJIT.cpp    Mon Nov 14 13:03:50 2011 -0800      
> 
> +++ b/js/src/methodjit/MethodJIT.cpp    Wed Nov 16 07:08:16 2011 +0800      
> 
> @@ -257,7 +257,7 @@                                                         
> 
>  #if defined(__GNUC__) && !defined(_WIN64)                                  
> 
>                                                                             
> 
>  /* If this assert fails, you need to realign VMFrame to 16 bytes. */       
> 
> -#ifdef JS_CPU_ARM                                                          
> 
> +#if defined(JS_CPU_ARM) || defined(JS_CPU_SPARC)                           
> 
>  JS_STATIC_ASSERT(sizeof(VMFrame) % 8 == 0);                                
> 
>  #else                                                                      
> 
>  JS_STATIC_ASSERT(sizeof(VMFrame) % 16 == 0);

Apparently, this works fine.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Don't require 16 bytes alignment for VMFrame on sparc

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32bc6264f4bf

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/32bc6264f4bf